Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aioredis 1.3.1 dropped explicit loop requirement in API #179

Closed
edelvalle opened this issue Feb 9, 2020 · 0 comments · Fixed by #193
Closed

aioredis 1.3.1 dropped explicit loop requirement in API #179

edelvalle opened this issue Feb 9, 2020 · 0 comments · Fixed by #193

Comments

@edelvalle
Copy link

Your OS and runtime environment, and browser if applicable

Arch Linux, Python 3.8.1

What you expected to happen vs. what actually happened?

I expect no warnings, but the dependency aioredis when used in version 1.3.1 is issuing a warning in python 3.8+ that the loop parameter is deprecated.

See: aio-libs-abandoned/aioredis-py#666

A pip freeze output showing your package versions, not really required to reproduce this.

How you're running Channels (runserver? daphne/runworker? Nginx/Apache in front?):

I'm using runserver and uvicorn.

Console logs and full tracebacks of any errors

  /home/xigurat/.virtualenvs/iskra/lib/python3.8/site-packages/aioredis/connection.py:105: DeprecationWarning: The loop argument is deprecated
    warnings.warn("The loop argument is deprecated",
@edelvalle edelvalle mentioned this issue Feb 11, 2020
Closed
edelvalle added a commit to edelvalle/channels_redis that referenced this issue May 27, 2020
@edelvalle
Merge pull request #1 from bjd183/master
8ccd27b 
Trying to slove django#179 (aioredis 1.3.1 dropped explicit loop requirement in API)
wmorrell added a commit to wmorrell/channels_redis that referenced this issue May 27, 2020
@wmorrell
Check aioredis version for deprecated parameter
95773a6 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
wmorrell added a commit to wmorrell/channels_redis that referenced this issue Jun 15, 2020
@wmorrell
Check aioredis version for deprecated parameter
d6d3bd9 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
@wmorrell wmorrell mentioned this issue Jun 25, 2020
Merged
carltongibson pushed a commit that referenced this issue Jun 25, 2020
@wmorrell @carltongibson
Check aioredis version for deprecated parameter
132efcf 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and #179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
dudleyhunt86 added a commit to dudleyhunt86/channels_redis-python-dev that referenced this issue Oct 7, 2022
@dudleyhunt86
Check aioredis version for deprecated parameter
d0a892c 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
goldentroll added a commit to goldentroll/channels_redis that referenced this issue Mar 14, 2023
@goldentroll
Check aioredis version for deprecated parameter
a19d4b4 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
jonmzeiset pushed a commit to jonmzeiset/channels_redis that referenced this issue Jan 22, 2024
@wmorrell @carltongibson
Check aioredis version for deprecated parameter
6443a14 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
jonmzeiset pushed a commit to jonmzeiset/channels_redis that referenced this issue Feb 22, 2024
@wmorrell @carltongibson
Check aioredis version for deprecated parameter
7dd069a 
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling
create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179.

When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop
parameter. Otherwise, continue to include the parameter for the older
versions that expect it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for DeprecationWarning in aioredis dependency wmorrell/channels_redis
1 participant
@edelvalle