revert accidental dupe of _register_s3_events #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks to have been accidentally inserted in aio-libs@3faf885 — on the basis that the line is identical to the next one. This actually causes failures for me down in the bowels of botocore, as it tries to rewrite to 'virtual' urls or something and I get a failure `s3-accelerate.amazonaws.com` cannot be found.... this is because my bucket subdomain has been stripped out (there's no DNS entry for `s3-accelerate.amazonaws.com` which becomes the target after the second `_register_s3_events` call; the bucket is stripped from the URL) FYI In a previous debug session when I thought the problem was in botocore, I traced the problem to some operations that were introduced in boto/botocore@28b8831
|
ooo thanks, wonder how that happened. Would be nice if we port a test to check for this |
|
I noticed a comment in botocore along the lines of 'this is safe to change the subdomain as we've already ' ... something related to virtual endpoints/urls which I didn't understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks to have been accidentally inserted in 3faf885 — on the basis that the line is identical to the next one.
This actually causes failures for me down in the bowels of botocore, as it tries to rewrite to 'virtual' urls or something and I get a failure
s3-accelerate.amazonaws.comcannot be found.... this is because my bucket subdomain has been stripped out (there's no DNS entry fors3-accelerate.amazonaws.comwhich becomes the target after the second_register_s3_eventscall; the bucket is stripped from the URL)FYI In a previous debug session when I thought the problem was in botocore, I traced the problem to some operations that were introduced in boto/botocore@28b8831