Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert accidental dupe of _register_s3_events #867

Merged
merged 1 commit into from
Nov 26, 2021

Commits on Jun 3, 2021

  1. revert accidental dupe of _register_s3_events

    This looks to have been accidentally inserted in aio-libs@3faf885 — on the basis that the line is identical to the next one.
    
    This actually causes failures for me down in the bowels of botocore, as it tries to rewrite to 'virtual' urls or something and I get a failure `s3-accelerate.amazonaws.com` cannot be found.... this is because my bucket subdomain has been stripped out (there's no DNS entry for `s3-accelerate.amazonaws.com` which becomes the target after the second `_register_s3_events` call; the bucket is stripped from the URL)
    
    FYI In a previous debug session when I thought the problem was in botocore, I traced the problem to some operations that were introduced in boto/botocore@28b8831
    eoghanmurray authored Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3c75f07 View commit details
    Browse the repository at this point in the history