Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sendfile with TLS/SSL transport #512

Closed
jashandeep-sohi opened this issue Sep 17, 2015 · 3 comments
Closed

sendfile with TLS/SSL transport #512

jashandeep-sohi opened this issue Sep 17, 2015 · 3 comments
Labels
outdated

Comments

@jashandeep-sohi
Copy link
Contributor

I was thinking about TLS/SSL today, and just realised that the current implementation doesn't take that into account.

We need a way to force _sendfile_fallback when ssl=True in loop.create_server.
I was thinking, if transport.get_extra_info('sslcontext', False) is True then we fallback. What do you think?
@asvetlov
Copy link
Member

Good catch! Please make a PR.

jashandeep-sohi added a commit to jashandeep-sohi/aiohttp that referenced this issue Sep 18, 2015
@jashandeep-sohi
Fix issue aio-libs#512: force sendfile fallback when using SSL.
ffc7982
@jashandeep-sohi jashandeep-sohi mentioned this issue Sep 18, 2015
Merged
asvetlov added a commit that referenced this issue Sep 19, 2015
@asvetlov
Merge pull request #513 from jashandeep-sohi/sendfile-ssl
7c43151 
Fix issue #512: force sendfile fallback when using SSL.
@asvetlov
Copy link
Member

Fixed

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @jashandeep-sohi