Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #512: force sendfile fallback when using SSL. #513

Merged
merged 2 commits into from
Sep 19, 2015

Conversation

jashandeep-sohi
Copy link
Contributor

See issue #512.

@asvetlov
Copy link
Member

Please add a test to never forget about ssl again.

@jashandeep-sohi
Copy link
Contributor Author

I've just added a single test to StaticFileMixin which runs using a SSL server.
Or would it better to test everything with & without SSL?

@asvetlov
Copy link
Member

No, one test is enough. Thanks!

asvetlov added a commit that referenced this pull request Sep 19, 2015
Fix issue #512: force sendfile fallback when using SSL.
@asvetlov asvetlov merged commit 7c43151 into aio-libs:master Sep 19, 2015
@jashandeep-sohi jashandeep-sohi deleted the sendfile-ssl branch September 19, 2015 01:23
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants