Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching tail pattern in add_route/add_* handling not working as expected in 3.10.0 #8567

Closed
1 task done
CoMPaTech opened this issue Aug 1, 2024 · 3 comments · Fixed by #8566
Closed
1 task done
Labels
Milestone

Comments

@CoMPaTech
Copy link

Describe the bug

The usage of https://docs.aiohttp.org/en/stable/faq.html#how-do-i-create-a-route-that-matches-urls-with-a-given-prefix seems to yield different results in 3.10.0 than in 3.9.5 for a certain condition. I've included a gist in 'reproduce' which mostly mimics what our code handles

While our code might not be the neatest, we use this for our testsuite (hence no functional user issue) here https://github.com/plugwise/python-plugwise/blob/672335ddf766799df5a8d0ba32d7d04332b8a5a2/tests/test_init.py#L114 with the constants defined around L29

To Reproduce

https://gist.github.com/CoMPaTech/541eb68906431933d2b3ea48e886b92b

Expected behavior

Parsing incoming URLs (for example) PUT /core/locations;id=c50f167537524366a5af7aa3942feb1e/thermostat;id=711861a52ed84f37a2d854afba34d9e6 While we also frown upon the url setup, it's what the physical boxes have in their firmware so beyond our ability to change.

Logs/tracebacks

See gist I nto reproduce

Python Version

3.12

aiohttp Version

3.10.0 (failing)
3.9.5 and earlier (functioning as expected)

multidict Version

6.0.5

yarl Version

1.9.4

OS

Able to reproduce in several containers, ubuntu and macOS (regardless of version)

Related component

Server

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@CoMPaTech CoMPaTech added the bug label Aug 1, 2024
@CoMPaTech
Copy link
Author

cc @bdraco

@bdraco
Copy link
Member

bdraco commented Aug 1, 2024

Can you try the change in #8566 ?

@bdraco bdraco added this to the 3.10.1 milestone Aug 1, 2024
@CoMPaTech
Copy link
Author

Sorry, should have added that #8566 (manually patching in gist venv and module venv) works as intended and working with 3.9.5

bdraco pushed a commit that referenced this issue Aug 1, 2024
…able is preceded by a fixed string after a slash (#8578)

Co-authored-by: J. Nick Koston <nick@koston.org>
fix for a regression in 3.10.x. Regressed in #7829 fixes #8567
bdraco pushed a commit that referenced this issue Aug 1, 2024
…able is preceded by a fixed string after a slash (#8579)

Co-authored-by: J. Nick Koston <nick@koston.org>
fix for a regression in 3.10.x. Regressed in #7829 fixes #8567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants