[PR #8566/f3a1afc5 backport][3.11] Fix url dispatcher index when variable is preceded by a fixed string after a slash #8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.11 #8579 +/- ##
==========================================
- Coverage 97.57% 97.51% -0.07%
==========================================
Files 108 108
Lines 33634 33652 +18
Branches 4034 4035 +1
==========================================
- Hits 32819 32815 -4
- Misses 594 612 +18
- Partials 221 225 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.11/f3a1afc51665d9d2180606f250f492a61623ac6b/pr-8566
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8566 as merged into master (f3a1afc).
What do these changes do?
Fix url dispatcher index when variable is preceded by a fixed string after a slash. We need to strip off the fixed string when creating the index key so we can match against the path at that part of the url.
Are there changes in behavior for the user?
Bugfix for a regression in 3.10.x. Regressed in #7829 fixes #8567
Is it a substantial burden for the maintainers to support this?
no