Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup to wss/ws fix #8513

Merged
merged 9 commits into from
Jul 20, 2024
Merged

Small cleanup to wss/ws fix #8513

merged 9 commits into from
Jul 20, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 17, 2024

followup to #8482

What do these changes do?

post merge review comments #8482 (comment) #8482 (comment)

Are there changes in behavior for the user?

n/a

Is it a substantial burden for the maintainers to support this?

no

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Jul 17, 2024
tests/test_client_session.py Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (43b10dc) to head (e695ba6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8513      +/-   ##
==========================================
- Coverage   97.62%   97.55%   -0.07%     
==========================================
  Files         107      107              
  Lines       33262    33262              
  Branches     3905     3905              
==========================================
- Hits        32472    32450      -22     
- Misses        571      589      +18     
- Partials      219      223       +4     
Flag Coverage Δ
CI-GHA 97.48% <100.00%> (-0.06%) ⬇️
OS-Linux 97.14% <100.00%> (-0.06%) ⬇️
OS-Windows 95.66% <100.00%> (ø)
OS-macOS 96.87% <100.00%> (ø)
Py-3.10.11 97.01% <100.00%> (ø)
Py-3.10.14 96.96% <100.00%> (ø)
Py-3.11.9 97.18% <100.00%> (ø)
Py-3.12.4 97.31% <100.00%> (ø)
Py-3.8.10 95.43% <100.00%> (ø)
Py-3.8.18 96.85% <100.00%> (ø)
Py-3.9.13 97.00% <100.00%> (ø)
Py-3.9.19 96.96% <100.00%> (ø)
Py-pypy7.3.16 ?
VM-macos 96.87% <100.00%> (ø)
VM-ubuntu 97.14% <100.00%> (-0.06%) ⬇️
VM-windows 95.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGES/8481.bugfix.rst Outdated Show resolved Hide resolved
CHANGES/8481.bugfix.rst Outdated Show resolved Hide resolved
CHANGES/8481.bugfix.rst Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

@bdraco so I linked both the PR and the issue and this is how it renders: https://aiohttp--8513.org.readthedocs.build/en/8513/changes.html#features.

@webknjaz
Copy link
Member

I also updated the original note byline with proper credits

@bdraco
Copy link
Member Author

bdraco commented Jul 19, 2024

Thanks @webknjaz

My day job is eating up all my time right now. I should have a chance to followup this weekend

@webknjaz webknjaz closed this Jul 19, 2024
@webknjaz webknjaz reopened this Jul 19, 2024
CHANGES/6722.feature Outdated Show resolved Hide resolved
@bdraco
Copy link
Member Author

bdraco commented Jul 20, 2024

Thanks @webknjaz

I see what your intent was now. Much appreciated.

@bdraco bdraco enabled auto-merge (squash) July 20, 2024 12:58
@bdraco bdraco merged commit bbe90e5 into master Jul 20, 2024
34 of 35 checks passed
@bdraco bdraco deleted the wss_cleanup branch July 20, 2024 13:12
Copy link
Contributor

patchback bot commented Jul 20, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/bbe90e5d9bbb456221ae85024588a87be835d7a3/pr-8513

Backported as #8519

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 20, 2024
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
(cherry picked from commit bbe90e5)
@webknjaz
Copy link
Member

No problem! Sorry I was unable to relay it more clearly.. One day, I'll document it properly.

bdraco added a commit that referenced this pull request Jul 20, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants