-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small cleanup to wss/ws fix #8513
Conversation
followup to #8482
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8513 +/- ##
==========================================
- Coverage 97.62% 97.55% -0.07%
==========================================
Files 107 107
Lines 33262 33262
Branches 3905 3905
==========================================
- Hits 32472 32450 -22
- Misses 571 589 +18
- Partials 219 223 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bdraco so I linked both the PR and the issue and this is how it renders: https://aiohttp--8513.org.readthedocs.build/en/8513/changes.html#features. |
I also updated the original note byline with proper credits |
Thanks @webknjaz My day job is eating up all my time right now. I should have a chance to followup this weekend |
Thanks @webknjaz I see what your intent was now. Much appreciated. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8519 🤖 @patchback |
Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua> (cherry picked from commit bbe90e5)
No problem! Sorry I was unable to relay it more clearly.. One day, I'll document it properly. |
followup to #8482
What do these changes do?
post merge review comments #8482 (comment) #8482 (comment)
Are there changes in behavior for the user?
n/a
Is it a substantial burden for the maintainers to support this?
no