Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8513/bbe90e5d backport][3.10] Small cleanup to wss/ws fix #8519

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jul 20, 2024

This is a backport of PR #8513 as merged into master (bbe90e5).

followup to #8482

What do these changes do?

post merge review comments #8482 (comment) #8482 (comment)

Are there changes in behavior for the user?

n/a

Is it a substantial burden for the maintainers to support this?

no

Co-authored-by: Sviatoslav Sydorenko <wk@sydorenko.org.ua>
(cherry picked from commit bbe90e5)
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.48%. Comparing base (7160994) to head (c52ea4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8519      +/-   ##
==========================================
+ Coverage   97.41%   97.48%   +0.06%     
==========================================
  Files         108      108              
  Lines       33476    33476              
  Branches     4012     4012              
==========================================
+ Hits        32611    32633      +22     
+ Misses        635      617      -18     
+ Partials      230      226       -4     
Flag Coverage Δ
CI-GHA 97.39% <100.00%> (+0.05%) ⬆️
OS-Linux 97.06% <100.00%> (+0.05%) ⬆️
OS-Windows 94.71% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.72% <100.00%> (ø)
Py-3.10.11 96.84% <100.00%> (ø)
Py-3.10.14 96.80% <100.00%> (ø)
Py-3.11.9 97.03% <100.00%> (ø)
Py-3.12.4 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.44% <100.00%> (?)
Py-3.8.18 96.69% <100.00%> (ø)
Py-3.9.13 96.83% <100.00%> (-0.01%) ⬇️
Py-3.9.19 96.81% <100.00%> (+0.10%) ⬆️
Py-pypy7.3.16 96.37% <100.00%> (?)
VM-macos 96.72% <100.00%> (ø)
VM-ubuntu 97.06% <100.00%> (+0.05%) ⬆️
VM-windows 94.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit fe43939 into 3.10 Jul 20, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/bbe90e5d9bbb456221ae85024588a87be835d7a3/pr-8513 branch July 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant