Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add followup changelog message for #5278 #8558

Merged
merged 8 commits into from
Aug 1, 2024
Merged

Add followup changelog message for #5278 #8558

merged 8 commits into from
Aug 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 31, 2024 •
edited
Loading

closes #8555

What do these changes do?

Improve the changelog documentation for #5278

#5278 removed the deprecation warning about having a running event loop and replaced it with
asyncio.get_running_loop() which will raise RuntimeError if there is no running loop.

Since the deprecation was done in #3372, which first appeared in https://github.com/aio-libs/aiohttp/releases/tag/v3.5.0 (~5 years, 7 months ago), reverting and extending the deprecation period did not seem warranted as five years should be enough notice.

@bdraco bdraco added the backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot label Jul 31, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jul 31, 2024
@bdraco bdraco added this to the 3.10.1 milestone Jul 31, 2024
bdraco
bdraco commented Jul 31, 2024
View reviewed changes
CHANGES/8555.breaking.rst Outdated Show resolved Hide resolved
bdraco
bdraco commented Jul 31, 2024
View reviewed changes
CHANGES/8555.breaking.rst Outdated Show resolved Hide resolved
bdraco
bdraco commented Jul 31, 2024
View reviewed changes
CHANGES/8555.breaking.rst Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review July 31, 2024 02:47
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (7ffb847) to head (4e67c38).
Report is 866 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8558   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         107      107           
  Lines       33403    33403           
  Branches     3923     3923           
=======================================
  Hits        32631    32631           
  Misses        559      559           
  Partials      213      213
Flag Coverage Δ
CI-GHA 97.59% <ø> (ø)
OS-Linux 97.25% <ø> (ø)
OS-Windows 95.64% <ø> (ø)
OS-macOS 96.92% <ø> (ø)
Py-3.10.11 97.06% <ø> (ø)
Py-3.10.14 97.00% <ø> (ø)
Py-3.11.9 97.23% <ø> (ø)
Py-3.12.4 97.36% <ø> (-0.01%) ⬇️
Py-3.8.10 95.40% <ø> (ø)
Py-3.8.18 96.89% <ø> (ø)
Py-3.9.13 97.05% <ø> (ø)
Py-3.9.19 97.00% <ø> (ø)
Py-pypy7.3.16 96.57% <ø> (ø)
VM-macos 96.92% <ø> (ø)
VM-ubuntu 97.25% <ø> (ø)
VM-windows 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

webknjaz
webknjaz reviewed Aug 1, 2024
View reviewed changes
CHANGES/8555.breaking.rst Outdated Show resolved Hide resolved
@bdraco @webknjaz
Update CHANGES/8555.breaking.rst
c84dff7 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
@bdraco
Copy link
Member Author

bdraco commented Aug 1, 2024

This likely affects ClientSession as well so we should add that to the list

@bdraco bdraco added the backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot label Aug 1, 2024
@bdraco bdraco merged commit e48acaf into master Aug 1, 2024
38 of 39 checks passed
@bdraco bdraco deleted the followup_5278 branch August 1, 2024 16:54
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 1, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/e48acaf7dd689dfb8f8f424257e463fdd0cec86a/pr-8558

Backported as #8576

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 1, 2024
@bdraco @patchback
Add followup changelog message for #5278 (#8558)
612e38e 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
(cherry picked from commit e48acaf)
@patchback patchback bot mentioned this pull request Aug 1, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Aug 1, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/e48acaf7dd689dfb8f8f424257e463fdd0cec86a/pr-8558

Backported as #8577

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 1, 2024
@bdraco @patchback
Add followup changelog message for #5278 (#8558)
473a9aa 
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
(cherry picked from commit e48acaf)
@patchback patchback bot mentioned this pull request Aug 1, 2024
Merged
bdraco pushed a commit that referenced this pull request Aug 1, 2024
@patchback
[PR #8558/e48acaf7 backport][3.10] Add followup changelog message for #…
6dff116 
…5278 (#8576)

Co-authored-by: J. Nick Koston <nick@koston.org>
closes #8555
bdraco pushed a commit that referenced this pull request Aug 1, 2024
@patchback
[PR #8558/e48acaf7 backport][3.11] Add followup changelog message for #…
13d36ef 
…5278 (#8577)

Co-authored-by: J. Nick Koston <nick@koston.org>
closes #8555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.

RuntimeError: no running event loop
2 participants
@bdraco @webknjaz