Drop Python 3.6 support #5278

asvetlov · 2020-11-23T14:27:33Z

Python 3.6 is close to EOL, aiohttp 4.0 is not released yet.
Dropping Python 3.6 for aiohttp 4.0 allows dropping a bunch of backward compatibility shims.

webknjaz · 2020-11-23T14:38:28Z

setup.py

@@ -5,8 +5,8 @@

 from setuptools import Extension, setup

-if sys.version_info < (3, 6):
-    raise RuntimeError("aiohttp 4.x requires Python 3.6+")
+if sys.version_info < (3, 7):


NOTE: I believe that with this change, we'll be able to migrate most of setup.py to setup.cfg since CPython 3.7.0 ships pip==10.0.1 and setuptools==39.0.1.
setup.cfg support was added in setuptools 30.3.0 and Requires-Python support has been added in pip 9.0.0.
Meaning that it's virtually impossible to hit this condition under the supported Python version. Add the platform wheels that we ship and you'll see that in 99% of cases users won't even run setup.py.

P.S. This is a topic for a separate PR, I just wanted to post some thoughts here.

I support the proposal (in a separate PR) but don't want to apply the change myself.
Regarding binary wheels -- the case number 1 when people build from tarball are Alpine Linux users.

webknjaz · 2020-11-23T14:40:50Z

Looks like you also need to drop 3.6 from GHA

asvetlov · 2020-11-23T15:15:18Z

Looks like you also need to drop 3.6 from GHA

Ooops. Done

codecov · 2020-11-23T19:28:50Z

Codecov Report

Merging #5278 (2127b3a) into master (e65f1a9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5278      +/-   ##
==========================================
- Coverage   97.53%   97.52%   -0.01%     
==========================================
  Files          43       43              
  Lines        8818     8784      -34     
  Branches     1418     1410       -8     
==========================================
- Hits         8601     8567      -34     
- Misses        102      103       +1     
+ Partials      115      114       -1

Flag	Coverage Δ
unit	`97.41% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
aiohttp/connector.py	`96.48% <100.00%> (-0.32%)`	⬇️
aiohttp/cookiejar.py	`98.78% <100.00%> (+<0.01%)`	⬆️
aiohttp/helpers.py	`96.78% <100.00%> (+0.22%)`	⬆️
aiohttp/pytest_plugin.py	`97.45% <100.00%> (-0.05%)`	⬇️
aiohttp/resolver.py	`93.18% <100.00%> (ø)`
aiohttp/web.py	`99.14% <100.00%> (-0.01%)`	⬇️
aiohttp/web_protocol.py	`92.28% <100.00%> (ø)`
aiohttp/web_runner.py	`97.76% <100.00%> (-0.01%)`	⬇️
aiohttp/web_server.py	`94.28% <100.00%> (-0.16%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65f1a9...2127b3a. Read the comment docs.

(cherry picked from commit 0f0c375)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

closes #8555

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com> (cherry picked from commit e48acaf)

…5278 (#8576) Co-authored-by: J. Nick Koston <nick@koston.org> closes #8555

…5278 (#8577) Co-authored-by: J. Nick Koston <nick@koston.org> closes #8555

Drop Python 3.6 support

d20ccc4

asvetlov requested a review from webknjaz as a code owner November 23, 2020 14:27

Add CHANGES

338f8d8

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 23, 2020

webknjaz reviewed Nov 23, 2020

View reviewed changes

Cleanup GHA

916bce7

asvetlov added 3 commits November 23, 2020 17:31

Cleanup

2240f96

Disable PyPy (again)

ce7ff2c

Merge branch 'master' into drop-py3.6

2127b3a

asvetlov merged commit 0f0c375 into master Nov 23, 2020

asvetlov deleted the drop-py3.6 branch November 23, 2020 20:08

reteps mentioned this pull request Dec 26, 2020

Threading, Local Downloading, Save Patterns, Extractor Class sec-edgar/sec-edgar#150

Merged

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021

Drop Python 3.6 support (aio-libs#5278)

acc8d44

commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021

Drop Python 3.6 support (aio-libs#5278)

986bb71

aaraney mentioned this pull request Jun 29, 2021

nwis-client latest builds broken when installed on Python 3.6 NOAA-OWP/hydrotools#98

Closed

bdraco pushed a commit that referenced this pull request Jul 17, 2024

Drop Python 3.6 support (#5278)

c61e1e5

(cherry picked from commit 0f0c375)

bdraco pushed a commit that referenced this pull request Jul 17, 2024

Drop Python 3.6 support (#5278)

76c0843

(cherry picked from commit 0f0c375)

bdraco pushed a commit that referenced this pull request Jul 17, 2024

Drop Python 3.6 support (#5278)

c989e29

(cherry picked from commit 0f0c375)

bdraco pushed a commit that referenced this pull request Jul 17, 2024

Drop Python 3.6 support (#5278)

e28da47

(cherry picked from commit 0f0c375)

bdraco added a commit that referenced this pull request Jul 17, 2024

[PR #5278/0f0c3759 backport][3.10] Drop Python 3.6 support (#8512)

266559c

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

bdraco mentioned this pull request Jul 30, 2024

RuntimeError: no running event loop #8555

Closed

1 task

bdraco added a commit that referenced this pull request Jul 31, 2024

Add followup changelog message for #5278

adb73f5

closes #8555

bdraco mentioned this pull request Jul 31, 2024

Add followup changelog message for #5278 #8558

Merged

bdraco added a commit that referenced this pull request Aug 1, 2024

Add followup changelog message for #5278 (#8558)

e48acaf

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>

patchback bot pushed a commit that referenced this pull request Aug 1, 2024

Add followup changelog message for #5278 (#8558)

612e38e

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com> (cherry picked from commit e48acaf)

patchback bot mentioned this pull request Aug 1, 2024

[PR #8558/e48acaf7 backport][3.10] Add followup changelog message for #5278 #8576

Merged

patchback bot pushed a commit that referenced this pull request Aug 1, 2024

Add followup changelog message for #5278 (#8558)

473a9aa

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com> (cherry picked from commit e48acaf)

patchback bot mentioned this pull request Aug 1, 2024

[PR #8558/e48acaf7 backport][3.11] Add followup changelog message for #5278 #8577

Merged

bdraco pushed a commit that referenced this pull request Aug 1, 2024

[PR #8558/e48acaf7 backport][3.10] Add followup changelog message for #…

6dff116

…5278 (#8576) Co-authored-by: J. Nick Koston <nick@koston.org> closes #8555

bdraco pushed a commit that referenced this pull request Aug 1, 2024

[PR #8558/e48acaf7 backport][3.11] Add followup changelog message for #…

13d36ef

…5278 (#8577) Co-authored-by: J. Nick Koston <nick@koston.org> closes #8555

This was referenced Aug 1, 2024

[3.10] Restore the ability to create objects without a running event loop #8580

Closed

[3.11] Restore the ability to create objects without a running event loop #8582

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop Python 3.6 support #5278

Drop Python 3.6 support #5278

asvetlov commented Nov 23, 2020

webknjaz Nov 23, 2020

asvetlov Nov 23, 2020

webknjaz commented Nov 23, 2020

asvetlov commented Nov 23, 2020

codecov bot commented Nov 23, 2020 •

edited

Loading

Drop Python 3.6 support #5278

Drop Python 3.6 support #5278

Conversation

asvetlov commented Nov 23, 2020

webknjaz Nov 23, 2020

Choose a reason for hiding this comment

asvetlov Nov 23, 2020

Choose a reason for hiding this comment

webknjaz commented Nov 23, 2020

asvetlov commented Nov 23, 2020

codecov bot commented Nov 23, 2020 • edited Loading

Codecov Report

codecov bot commented Nov 23, 2020 •

edited

Loading