Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Restore the ability to create objects without a running event loop #8580

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 1, 2024

Alternate solution for #8555, partial revert of #8512 (originally #5278)

I'm not sold on that idea because Python has deprecated calling asyncio.get_event_loop() without a running event loop. After all, the behavior is confusing. Even if we did revert this, it's kicking the can down the road until it becomes an error.

https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.get_event_loop
Screenshot 2024-08-01 at 2 27 12 PM

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 1, 2024
@bdraco bdraco mentioned this pull request Aug 1, 2024
1 task
@bdraco bdraco closed this Aug 1, 2024
@bdraco bdraco reopened this Aug 1, 2024
@bdraco bdraco changed the title Restore fallback to get_event_loop when the event loop is not running Restore the ability to create objects without a running event loop Aug 1, 2024
@bdraco bdraco changed the title Restore the ability to create objects without a running event loop [3.10] Restore the ability to create objects without a running event loop Aug 1, 2024
@bdraco bdraco modified the milestones: 3.10, 3.10.1 Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (9ed3841) to head (63811fa).
Report is 196 commits behind head on 3.10.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8580   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files         108      108           
  Lines       33674    33702   +28     
  Branches     4038     4042    +4     
=======================================
+ Hits        32865    32893   +28     
  Misses        590      590           
  Partials      219      219           
Flag Coverage Δ
CI-GHA 97.50% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.17% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.71% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.84% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 96.90% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.13% <100.00%> (+<0.01%) ⬆️
Py-3.12.4 97.25% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.44% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.79% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.94% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.91% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.47% <100.00%> (-0.01%) ⬇️
VM-macos 96.84% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.17% <100.00%> (+<0.01%) ⬆️
VM-windows 94.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this Aug 2, 2024
@bdraco bdraco removed this from the 3.10.1 milestone Aug 2, 2024
@bdraco bdraco deleted the restore_event_loop branch September 24, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant