Switch WebSocketWriter to use removesuffix to drop compression trailer
#9795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
added
bot:chronographer:skip
CodSpeed Performance ReportMerging #9795 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9795 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 118 118
Lines 36007 36004 -3
Branches 4281 4280 -1
=======================================
- Hits 35536 35534 -2
Misses 316 316
+ Partials 155 154 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
We have no benchmark for compression. We need to add that before considering this change |
This was referenced Nov 11, 2024
Now that Python 3.8 is no longer supported we can use removesuffix
bdraco
force-pushed
the
websocket_writer_ref
branch
from
02c1027
to
3c6d870
Compare
bdraco
changed the title
removesuffix
bdraco
changed the title
removesuffixremovesuffix to drop compression trailer
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9805 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
(cherry picked from commit fcb790b)
bdraco
added a commit
that referenced
this pull request
Nov 11, 2024
…ovesuffix` to drop compression trailer (#9805) Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Python 3.8 is no longer supported (
masterand3.11only) we can usebytes.removesuffixThis also takes care of one uncovered branch in the tests and brings the
WebSocketWriterup to 100% line/branch coverageIts small improvement, considering how much time the compression actually takes. It will be >10% if using
isalfor compression though since the compression overhead is far less when using alternativezlibsee #9798