Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9799/d40b1839 backport][3.10] Add compressed WebSocketWriter benchmark #9801

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 11, 2024

This is a backport of PR #9799 as merged into master (d40b183).

To validate if #9795 is a good change or not

@bdraco bdraco enabled auto-merge (squash) November 11, 2024 14:20
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (1ce9953) to head (3ae78d6).
Report is 1 commits behind head on 3.10.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #9801   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         113      113           
  Lines       35707    35716    +9     
  Branches     4300     4302    +2     
=======================================
+ Hits        34962    34971    +9     
  Misses        553      553           
  Partials      192      192           
Flag Coverage Δ
CI-GHA 97.80% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.50% <100.00%> (+<0.01%) ⬆️
OS-Windows 95.10% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.05% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.04% <100.00%> (+0.04%) ⬆️
Py-3.11.10 97.07% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.13% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.57% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.55% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.49% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.83% <100.00%> (-0.01%) ⬇️
Py-3.9.13 96.97% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.95% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 96.52% <100.00%> (-0.01%) ⬇️
VM-macos 97.20% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.50% <100.00%> (+<0.01%) ⬆️
VM-windows 95.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco disabled auto-merge November 11, 2024 14:26
@bdraco bdraco enabled auto-merge (squash) November 11, 2024 14:27
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #9801 will not alter performance

Comparing patchback/backports/3.10/d40b1839dbd794db89b82dd36530cd40718b8b07/pr-9799 (3ae78d6) with 3.10 (1ce9953)

Summary

✅ 16 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark 3.10 patchback/backports/3.10/d40b1839dbd794db89b82dd36530cd40718b8b07/pr-9799 Change
🆕 test_send_one_hundred_websocket_compressed_messages[pyloop] N/A 3.3 ms N/A

@bdraco bdraco merged commit 569fa13 into 3.10 Nov 11, 2024
37 of 38 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/d40b1839dbd794db89b82dd36530cd40718b8b07/pr-9799 branch November 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant