Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust client GET read benchmarks to include chunked and content-length #9827

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 12, 2024

chunked has a different performance profile than content-length (chunked is slower currently). We need benchmarks for both.

I'm still not sure if #9823 is a good change or not so I'm adding more benchmarks to validate it

@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 12, 2024
Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9827 will not alter performance

Comparing adjust_read_benchmarks_content_length_chunked (9907357) with master (dc7eee6)

Summary

✅ 17 untouched benchmarks

🆕 6 new benchmarks
⁉️ 3 (👁 3) dropped benchmarks

Benchmarks breakdown

Benchmark master adjust_read_benchmarks_content_length_chunked Change
🆕 test_one_hundred_get_requests_with_1mib_chunked_payload[pyloop] N/A 319.8 ms N/A
🆕 test_one_hundred_get_requests_with_1mib_content_length_payload[pyloop] N/A 300.1 ms N/A
👁 test_one_hundred_get_requests_with_1mib_payload[pyloop] 300.1 ms N/A N/A
🆕 test_one_hundred_get_requests_with_2048_chunked_payload[pyloop] N/A 39 ms N/A
🆕 test_one_hundred_get_requests_with_2048_content_length_payload[pyloop] N/A 38.8 ms N/A
👁 test_one_hundred_get_requests_with_2048_payload[pyloop] 38.7 ms N/A N/A
🆕 test_one_hundred_get_requests_with_32768_chunked_payload[pyloop] N/A 49 ms N/A
🆕 test_one_hundred_get_requests_with_32768_content_length_payload[pyloop] N/A 43.1 ms N/A
👁 test_one_hundred_get_requests_with_32768_payload[pyloop] 42.9 ms N/A N/A

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.70%. Comparing base (dc7eee6) to head (9907357).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9827   +/-   ##
=======================================
  Coverage   98.69%   98.70%           
=======================================
  Files         118      118           
  Lines       36063    36120   +57     
  Branches     4284     4290    +6     
=======================================
+ Hits        35594    35651   +57     
  Misses        315      315           
  Partials      154      154           
Flag Coverage Δ
CI-GHA 98.59% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.27% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.06% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.36% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.75% <100.00%> (-0.05%) ⬇️
Py-3.11.10 97.86% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.25% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.34% <100.00%> (+0.01%) ⬆️
Py-3.13.0 98.28% <100.00%> (-0.05%) ⬇️
Py-3.9.13 97.12% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.71% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.29% <100.00%> (+<0.01%) ⬆️
VM-macos 97.36% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.27% <100.00%> (+<0.01%) ⬆️
VM-windows 96.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 12, 2024 14:54
@bdraco
Copy link
Member Author

bdraco commented Nov 12, 2024

Even with tracking syscalls, chunked 1MiB is spending the majority of its time in memcpy

Screenshot 2024-11-12 at 8 56 41 AM

@bdraco bdraco merged commit 14fcfd4 into master Nov 12, 2024
41 of 42 checks passed
@bdraco bdraco deleted the adjust_read_benchmarks_content_length_chunked branch November 12, 2024 15:01
Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827

Backported as #9829

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented Nov 12, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827

Backported as #9830

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 12, 2024
bdraco added a commit that referenced this pull request Nov 12, 2024
…to include chunked and content-length (#9830)

Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco added a commit that referenced this pull request Nov 12, 2024
…to include chunked and content-length (#9829)

Co-authored-by: J. Nick Koston <nick@koston.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant