-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust client GET read benchmarks to include chunked and content-length #9827
Conversation
CodSpeed Performance ReportMerging #9827 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9827 +/- ##
=======================================
Coverage 98.69% 98.70%
=======================================
Files 118 118
Lines 36063 36120 +57
Branches 4284 4290 +6
=======================================
+ Hits 35594 35651 +57
Misses 315 315
Partials 154 154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #9829 🤖 @patchback |
Backport to 3.11: 💚 backport PR created✅ Backport PR branch: Backported as #9830 🤖 @patchback |
…to include chunked and content-length (#9830) Co-authored-by: J. Nick Koston <nick@koston.org>
…to include chunked and content-length (#9829) Co-authored-by: J. Nick Koston <nick@koston.org>
chunked has a different performance profile than content-length (chunked is slower currently). We need benchmarks for both.
I'm still not sure if #9823 is a good change or not so I'm adding more benchmarks to validate it