Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9827/14fcfd4c backport][3.11] Adjust client GET read benchmarks to include chunked and content-length #9830

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 12, 2024

This is a backport of PR #9827 as merged into master (14fcfd4).

chunked has a different performance profile than content-length (chunked is slower currently). We need benchmarks for both.

I'm still not sure if #9823 is a good change or not so I'm adding more benchmarks to validate it

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #9830 will not alter performance

Comparing patchback/backports/3.11/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 (549adeb) with 3.11 (6894d4e)

Summary

✅ 17 untouched benchmarks

🆕 6 new benchmarks
⁉️ 3 (👁 3) dropped benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 Change
🆕 test_one_hundred_get_requests_with_1mib_chunked_payload[pyloop] N/A 319.4 ms N/A
🆕 test_one_hundred_get_requests_with_1mib_content_length_payload[pyloop] N/A 299.7 ms N/A
👁 test_one_hundred_get_requests_with_1mib_payload[pyloop] 299.7 ms N/A N/A
🆕 test_one_hundred_get_requests_with_2048_chunked_payload[pyloop] N/A 38.6 ms N/A
🆕 test_one_hundred_get_requests_with_2048_content_length_payload[pyloop] N/A 38.4 ms N/A
👁 test_one_hundred_get_requests_with_2048_payload[pyloop] 38.3 ms N/A N/A
🆕 test_one_hundred_get_requests_with_32768_chunked_payload[pyloop] N/A 48.6 ms N/A
🆕 test_one_hundred_get_requests_with_32768_content_length_payload[pyloop] N/A 42.6 ms N/A
👁 test_one_hundred_get_requests_with_32768_payload[pyloop] 42.6 ms N/A N/A

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (6894d4e) to head (549adeb).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9830   +/-   ##
=======================================
  Coverage   97.97%   97.98%           
=======================================
  Files         119      119           
  Lines       36170    36227   +57     
  Branches     4334     4340    +6     
=======================================
+ Hits        35439    35496   +57     
  Misses        546      546           
  Partials      185      185           
Flag Coverage Δ
CI-GHA 97.87% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.56% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.41% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.67% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.52% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.11% <100.00%> (-0.01%) ⬇️
Py-3.11.10 97.14% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.59% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.63% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.63% <100.00%> (+0.01%) ⬆️
Py-3.9.13 96.45% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.03% <100.00%> (+0.01%) ⬆️
Py-pypy7.3.16 96.60% <100.00%> (+<0.01%) ⬆️
VM-macos 96.67% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.56% <100.00%> (+<0.01%) ⬆️
VM-windows 94.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 12, 2024 15:18
@bdraco bdraco merged commit 9adc6c1 into 3.11 Nov 12, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/14fcfd4c21f63cf9d3bc1ba09e041411a71c8a7a/pr-9827 branch November 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant