refactor: add type hints to protocol #997
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ods
reviewed
Apr 14, 2024
Comment on lines
12
to
+14
| @classmethod | ||
| @abc.abstractmethod | ||
| def encode(cls, value): ... | ||
| def encode(self, value: Optional[T]) -> bytes: ... |
There was a problem hiding this comment.
Why self if it's declared as classmethod?
| import struct | ||
| from struct import error | ||
| from typing import Callable, Optional, TypeVar | ||
|
|
||
| from _typeshed import ReadableBuffer |
| def __init__(self, *fields): | ||
| if fields: | ||
| self.names, self.fields = zip(*fields) | ||
| else: | ||
| self.names, self.fields = (), () | ||
|
|
||
| def encode(self, item): | ||
| def encode(self, item) -> bytes: |
There was a problem hiding this comment.
Here is the problem: it violates the declaration in the abstract base class. And I see no simple way to fix it.
|
This PR seem to have been superseded, should it be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add type hints to the protocol module
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.