add typing to aiokafka/protocol/* #999
Conversation
dimastbk
force-pushed
the
typing-protocol-package
branch
from
f261e92
to
e4b20ab
Compare
|
Maybe rewrite all schemas using dataclasses? If it is not a problem for performance. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @classmethod | ||
| @abc.abstractmethod | ||
| def encode(cls, value): ... | ||
| def encode(cls, value: T) -> bytes: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
|
|
||
| @classmethod | ||
| @abc.abstractmethod | ||
| def decode(cls, data): ... | ||
| def decode(cls, data: BytesIO) -> T: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| magic: Literal[0], | ||
| attributes: int, | ||
| crc: int, | ||
| ) -> None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| attributes: int, | ||
| crc: int, | ||
| timestamp: int, | ||
| ) -> None: ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| array_of: ValueT | ||
|
|
||
| @overload | ||
| def __init__(self, array_of_0: ValueT): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| @overload | ||
| def __init__( | ||
| self, array_of_0: Tuple[str, ValueT], *array_of: Tuple[str, ValueT] | ||
| ): ... |
Check notice
Code scanning / CodeQL
Statement has no effect Note
| @@ -23,27 +25,29 @@ | |||
| ) | |||
| ) | |||
|
|
|||
| def encode(self): | |||
| def encode(self) -> bytes: | |||
Check notice
Code scanning / CodeQL
Mismatch between signature and use of an overridden method Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
- Coverage 95.44% 95.38% -0.07%
==========================================
Files 112 112
Lines 16702 16738 +36
Branches 2672 2691 +19
==========================================
+ Hits 15942 15966 +24
- Misses 479 485 +6
- Partials 281 287 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the review, sorry for 64 comments |
|
Hmm, we forgot about |
Changes
partial fixes #980
Add typing to all modules in protocol package.
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.