small fix #70
Merged
small fix #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warsaw
requested changes
Apr 19, 2017
aiosmtpd/smtp.py
Outdated
| @@ -195,7 +193,7 @@ def _handle_client(self): | |||
| log.info('%r handling connection', self.session.peer) | |||
| yield from self.push( | |||
| '220 {} {}'.format(self.hostname, self.__ident__)) | |||
| while not self._connection_closed: # pragma: no branch | |||
| while self.transport: # pragma: no branch | |||
There was a problem hiding this comment.
Could you make the check here and below a little more explicit? Rather than checking truthiness, please use while self.transport is not None
warsaw
added
the
tech-debt
Merged
|
Updated. |
warsaw
approved these changes
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small fix about fields usage - self.transport and self._connection_closed duplicate each other.