Fix Windows/AppVeyor failures and clean things up #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly this is to see what AppVeyor does on PRs now that the integration has landed.
warsaw
changed the title
|
@Mortal Check it out - no conditional and everything still passes. I wonder if #70 made that check redundant. It's not worth going back to see which change triggered that, so just getting rid of the conditional is good enough for me. There are a few other cleanups I can still make, and I want to experiment with something in tox/coverage, but this does improve things quite a bit. |
No special pragmas are required any more.
|
Okay, removing the conditional doesn't cause the tests to fail, but it does cause traceback spew on the console. I'm deferring that onto issue #83 |
Closed
|
Closes #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly this is to see what AppVeyor does on PRs now that the integration has
landed.