-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 support #1002
Python 3.13 support #1002
Conversation
@@ -199,12 +198,7 @@ jobs: | |||
uses: actions/setup-python@v5 | |||
with: | |||
python-version: ${{ matrix.pyver }} | |||
allow-prereleases: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdraco this should be kept long-term so that adding -dev
things in the future wouldn't require remembering to reimplement it once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I matched it to yarl
since I wasn't sure if 3.13-dev
would pull non rc
/stable
3.13
, and allow-prereleases: true
is still needed for 3.13
since its rc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like keeping -dev
will still work https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-python-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized there are other checks for -dev
though that we want to be fatal if 3.13 breaks though....so I'm not sure if reverting it makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, leave it as is. I usually like using a different syntax ~3.13.0-0
and check for ~
in other places. But I suppose it's not important to figure out right now. Something to remember at some point, perhaps.
I also didn't fully realize that this is about the action input. I typically have this in the check for allowing failures, which is what confused me and I overlooked the context.
needs #993 to pass
What do these changes do?
Support Python 3.13 along with wheels