Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 support #1002

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Python 3.13 support #1002

merged 4 commits into from
Sep 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024

needs #993 to pass

What do these changes do?

Support Python 3.13 along with wheels

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 9, 2024
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review September 9, 2024 22:37
@bdraco bdraco merged commit f3876fd into master Sep 9, 2024
44 of 48 checks passed
@bdraco bdraco deleted the py313 branch September 9, 2024 22:38
@@ -199,12 +198,7 @@ jobs:
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.pyver }}
allow-prereleases: >-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco this should be kept long-term so that adding -dev things in the future wouldn't require remembering to reimplement it once again.

Copy link
Member Author

@bdraco bdraco Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I matched it to yarl since I wasn't sure if 3.13-dev would pull non rc/stable 3.13, and allow-prereleases: true is still needed for 3.13 since its rc

https://github.com/aio-libs/yarl/blob/eaf76414d44e72b022a7dee3b48bb532934a2f33/.github/workflows/ci-cd.yml#L226

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert that change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized there are other checks for -dev though that we want to be fatal if 3.13 breaks though....so I'm not sure if reverting it makes sense

Copy link
Member

@webknjaz webknjaz Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, leave it as is. I usually like using a different syntax ~3.13.0-0 and check for ~ in other places. But I suppose it's not important to figure out right now. Something to remember at some point, perhaps.

I also didn't fully realize that this is about the action input. I typically have this in the check for allowing failures, which is what confused me and I overlooked the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants