Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.13 support #1002
Python 3.13 support #1002
Changes from 3 commits
30f13d324e3f38ebda8acbc700a2File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdraco this should be kept long-term so that adding
-devthings in the future wouldn't require remembering to reimplement it once again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I matched it to
yarlsince I wasn't sure if3.13-devwould pull nonrc/stable3.13, andallow-prereleases: trueis still needed for3.13since itsrchttps://github.com/aio-libs/yarl/blob/eaf76414d44e72b022a7dee3b48bb532934a2f33/.github/workflows/ci-cd.yml#L226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like keeping
-devwill still work https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#specifying-a-python-versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized there are other checks for
-devthough that we want to be fatal if 3.13 breaks though....so I'm not sure if reverting it makes senseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, leave it as is. I usually like using a different syntax
~3.13.0-0and check for~in other places. But I suppose it's not important to figure out right now. Something to remember at some point, perhaps.I also didn't fully realize that this is about the action input. I typically have this in the check for allowing failures, which is what confused me and I overlooked the context.