Fix segfault import when multidict bundled with pyinstaller. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 75.81% 79.14% +3.32%
==========================================
Files 5 5
Lines 488 489 +1
==========================================
+ Hits 370 387 +17
+ Misses 118 102 -16
Continue to review full report at Codecov.
|
psf-chronographer
bot
added
the
bot:chronographer:provided
|
Sorry, I don't understand how it fixes the project. |
Mb better split this fix on two.
One interesting thing is that |
|
Things that bother me:
In conclusion, |
You right. For me, this |
|
I propose to close this PR and live #433 open until we don't understand what's going on in |
|
Agree |
aio-libs-github-bot bot
pushed a commit
that referenced
this pull request
Jan 18, 2021
Bumps [pytest-cov](https://github.com/pytest-dev/pytest-cov) from 2.10.1 to 2.11.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst">pytest-cov's changelog</a>.</em></p> <blockquote> <h2>2.11.0 (2021-01-18)</h2> <ul> <li>Bumped minimum coverage requirement to 5.2.1. This prevents reporting issues. Contributed by Mateus Berardo de Souza Terra in <code>[#433](pytest-dev/pytest-cov#433) <https://github.com/pytest-dev/pytest-cov/pull/433></code>_.</li> <li>Improved sample projects (from the <code>examples <https://github.com/pytest-dev/pytest-cov/tree/master/examples></code>_ directory) to support running <code>tox -e pyXY</code>. Now the example configures a suffixed coverage data file, and that makes the cleanup environment unnecessary. Contributed by Ganden Schaffner in <code>[#435](pytest-dev/pytest-cov#435) <https://github.com/pytest-dev/pytest-cov/pull/435></code>_.</li> <li>Removed the empty <code>console_scripts</code> entrypoint that confused some Gentoo build script. I didn't ask why it was so broken cause I didn't want to ruin my day. Contributed by Michał Górny in <code>[#434](pytest-dev/pytest-cov#434) <https://github.com/pytest-dev/pytest-cov/pull/434></code>_.</li> <li>Fixed the missing <code>coverage context <https://coverage.readthedocs.io/en/stable/contexts.html></code>_ when using subprocesses. Contributed by Bernát Gábor in <code>[#443](pytest-dev/pytest-cov#443) <https://github.com/pytest-dev/pytest-cov/pull/443></code>_.</li> <li>Updated the config section in the docs. Contributed by Pamela McA'Nulty in <code>[#429](pytest-dev/pytest-cov#429) <https://github.com/pytest-dev/pytest-cov/pull/429></code>_.</li> <li>Migrated CI to travis-ci.com (from .org).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/b45388d0bf81465759412c6b977c6a1fc5201346"><code>b45388d</code></a> Bump version: 2.10.1 → 2.11.0</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/bd7e8506d7c0d85ac10f3569b8da3584b80bc67c"><code>bd7e850</code></a> Fix link name.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/5f935d5dc281b470687147b28f90b09dc887efc3"><code>5f935d5</code></a> Update changelog.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/d3c382a7e7e933e9602f5a5445d03f6dc5138da0"><code>d3c382a</code></a> Skip this on 3.8+</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/a2493d5f1825568b1f66ff033a49f28437560cad"><code>a2493d5</code></a> Skip this on 3.8+</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/25eed212085ce9a2d5383a6a4a2b360d0d514f89"><code>25eed21</code></a> Turns out there were some internal changes in the pytester plugin.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/42d7705b26c3fdbd74cd81a01b8fe0f213d16095"><code>42d7705</code></a> Oops.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/4ce7ac3cb463e7a42b1f10da45aba3c5987d23de"><code>4ce7ac3</code></a> Update test deps.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/0eada98182c7e4754927d5eefdd5e1ae72a9062d"><code>0eada98</code></a> Update skel; migrate to travis-ci.com.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/6592810f4181091fbd284e013b5ed91c08e3a479"><code>6592810</code></a> Update setup.py</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-cov/compare/v2.10.1...v2.11.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fix segfault import when multidict bundled with pyinstaller.
Are there changes in behavior for the user?
No
Related issue number
#432
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.