[connection] update path challenge according to the draft [JF & CC] #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good catch. Would you mind cleaning up the patch (removing commented code and debug statements)? |
|
Hello @ElNiak any chance of getting the code into a shape I can merge it? |
|
Hello, sorry we forget about that it will be done asap ! |
|
The PR seems to completely break the test suite would you mind updating it? |
jlaine
reviewed
Feb 10, 2022
| @@ -1147,6 +1162,17 @@ def _find_network_path(self, addr: NetworkAddress) -> QuicNetworkPath: | |||
| self._logger.debug("Network path %s discovered", network_path.addr) | |||
| return network_path | |||
|
|
|||
| def _find_network_challenge(self) -> QuicNetworkPathChallenge: | |||
| # check existing network challenge | |||
| for idx, network_chall in enumerate(self._network_challenges): | |||
There was a problem hiding this comment.
This looks like a complicated way of saying "always take the last challenge in the list"?
jlaine
added
the
changes requested
|
Hi @ElNiak do you plan to complete the work on this PR? |
|
Closing this in favor of the approach of [#483]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to modify the PATH_CHALLENGE part of the connection.py to follow this rule that we found with a testing tool Ivy. The problem before was that if the PATH_RESPONSE was received on a different path the challenge was considered as failed.
JF & CC