Improved path challenge handling. #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 4976 4987 +11
=========================================
+ Hits 4976 4987 +11 ☔ View full report in Codecov by Sentry. |
|
This patch addresses the issue raised by [#189], though with a different implementation. It also addresses another issue, which is that we may need to reply to more than one remote challenge on the same path. Both sides are bounded, currently to 5 items, to avoid any possible resource attack. There are tests and coverage remains at 100%. |
|
I will lint this one further and push an update tonight or tomorrow morning |
rthalley
force-pushed
the
path-challenge
branch
from
a6feb06 to
f8eee22
Compare
jlaine
approved these changes
Jun 18, 2024
1) We are willing to reply to up to 5 outstanding challenges on a connection, as it is legal for a client to send more than one. We limit to 5 to prevent excessive challenging. 2) We now accept path challege responses on any network path, in accordance with RFC 9000 section 8.2.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are willing to reply to up to 5 outstanding challenges on a connection, as it is legal for a client to send more than one. We limit to 5 to prevent excessive challenging.
We now accept path challege responses on any network path, in accordance with RFC 9000 section 8.2.3.