-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint config] [*] [new] add eslint
v7
#2240
Conversation
Thanks, I already have this branch locally tho and it'll require a bit more than this. I'll repurpose the PR. |
eslint
v7
// disallow negation of the left operand of an in expression | ||
// deprecated in favor of no-unsafe-negation | ||
'no-negated-in-lhs': 'off', | ||
|
||
// Disallow assignments that can lead to race conditions due to usage of await or yield | ||
// https://eslint.org/docs/rules/require-atomic-updates | ||
// TODO: enable, semver-major | ||
// note: not enabled because it is very buggy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ljharb !
Would you mind to share some cases where you faced bugs in this rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s a couple threads on eslint core that are full of examples; i don’t have any off hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, might have guessed myself to look there. thx
CC @ljharb