Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ESLint 7.x #684

Merged
merged 3 commits into from
Jun 12, 2020
Merged

feat: Support ESLint 7.x #684

merged 3 commits into from
Jun 12, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented May 9, 2020

ESLint v7.0.0 is released 🎉

(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:


Closes #683

@coveralls
Copy link

coveralls commented May 9, 2020

Coverage Status

Coverage remained the same at 99.484% when pulling ef68b45 on MichaelDeBoey:eslint-7 into 573d39e on evcohen:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.484% when pulling 85b4d3a on MichaelDeBoey:eslint-7 into 573d39e on evcohen:master.

@ljharb

This comment has been minimized.

@MichaelDeBoey

This comment has been minimized.

@weyert
Copy link

weyert commented Jun 1, 2020

Anyway to get this PR progressing? Love to use this plugin with ESLint 7 :)

@kentcdodds
Copy link

Another ping. This is holding up the v4 release of react-scripts so I'm happy to pitch in as needed.

@MichaelDeBoey
Copy link
Contributor Author

@kentcdodds This one's currently waiting for eslint-config-airbnb-base (airbnb/javascript#2240) and jsx-ast-utils (jsx-eslint/jsx-ast-utils#97), which itself is also waiting for eslint-config-airbnb-base.

@ljharb
Copy link
Member

ljharb commented Jun 10, 2020

I'm not convinced it actually needs the jsx-ast-utils update, but eslint-config-airbnb-base certainly. That will be coming soon.

@ljharb ljharb mentioned this pull request Jun 10, 2020
19 tasks
@jessebeach
Copy link
Collaborator

@MichaelDeBoey thank you so much for this contribution. We'll get this in as soon as it is ready.

@ljharb ljharb self-assigned this Jun 11, 2020
…rm-flow-types`, `babel-eslint`, `babel-jest`, `coveralls`, `eslint-config-airbnb-base`, `eslint-plugin-flowtype`, `eslint-plugin-import`, `estraverse`, `in-publish`, `jest`, `minimist`, `rimraf`, `safe-publish-latest`
@ljharb
Copy link
Member

ljharb commented Jun 11, 2020

eslint-config-airbnb-base has been updated and I've rebased this PR. Tests are indeed failing, so it looks like we'll need the jsx-ast-utils update before proceeding.

@ljharb
Copy link
Member

ljharb commented Jun 11, 2020

rebased again with the latest jsx-ast-utils published

@ljharb ljharb force-pushed the eslint-7 branch 2 times, most recently from 3000cca to c93467a Compare June 12, 2020 02:23
@ljharb
Copy link
Member

ljharb commented Jun 12, 2020

It's failing because jsx-ast-utils is still using .start in at least one place. No need to update this PR please; I'll update jsx-ast-utils, and then rebase this PR once that's done :-)

@ljharb ljharb marked this pull request as ready for review June 12, 2020 03:01
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PRs and for bearing with the delays :-)

@ljharb ljharb merged commit b273fe5 into jsx-eslint:master Jun 12, 2020
@ljharb
Copy link
Member

ljharb commented Jun 12, 2020

@jessebeach are you working on a release soon, or should i cut one?

@MichaelDeBoey MichaelDeBoey deleted the eslint-7 branch June 12, 2020 08:11
@danez
Copy link

danez commented Jun 16, 2020

Can we please have a release?

@jessebeach
Copy link
Collaborator

Can we please have a release?

@kentcdodds & @danez yes, I'll have one out this week. Aiming for tomorrow, June 17th, 2020

cc/ @evcohen who I'll need for the NPM dance when the time comes.

@ljharb
Copy link
Member

ljharb commented Jun 16, 2020

@jessebeach i can get you any npm privileges you need; lmk if there's an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
7 participants