-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More comments #2630
base: master
Are you sure you want to change the base?
More comments #2630
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,10 @@ Other Style Guides | |
|
||
## Types | ||
|
||
*Explains what types are in Javascript* | ||
|
||
Programming languages all have built-in data structures, but these often differ from one language to another. This article attempts to list the built-in data structures available in JavaScript and what properties they have. These can be used to build other data structures. Wherever possible, comparisons with other languages are drawn. | ||
|
||
<a name="types--primitives"></a><a name="1.1"></a> | ||
- [1.1](#types--primitives) **Primitives**: When you access a primitive type you work directly on its value. | ||
|
||
|
@@ -73,6 +77,8 @@ Other Style Guides | |
- `symbol` | ||
- `bigint` | ||
|
||
*Goes over numbers* | ||
|
||
```javascript | ||
const foo = 1; | ||
let bar = foo; | ||
|
@@ -91,6 +97,8 @@ Other Style Guides | |
- `array` | ||
- `function` | ||
|
||
*Goes over arrays* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. as does this |
||
|
||
```javascript | ||
const foo = [1, 2]; | ||
const bar = foo; | ||
|
@@ -109,6 +117,8 @@ Other Style Guides | |
|
||
> Why? This ensures that you can’t reassign your references, which can lead to bugs and difficult to comprehend code. | ||
|
||
*Vars and Consts* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and this |
||
|
||
```javascript | ||
// bad | ||
var a = 1; | ||
|
@@ -141,6 +151,8 @@ Other Style Guides | |
<a name="references--block-scope"></a><a name="2.3"></a> | ||
- [2.3](#references--block-scope) Note that both `let` and `const` are block-scoped, whereas `var` is function-scoped. | ||
|
||
*Goes over scopes in Javascript* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and this |
||
|
||
```javascript | ||
// const and let only exist in the blocks they are defined in. | ||
{ | ||
|
@@ -162,6 +174,8 @@ Other Style Guides | |
<a name="objects--no-new"></a><a name="3.1"></a> | ||
- [3.1](#objects--no-new) Use the literal syntax for object creation. eslint: [`no-new-object`](https://eslint.org/docs/rules/no-new-object) | ||
|
||
*Goes over objects* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and this |
||
|
||
```javascript | ||
// bad | ||
const item = new Object(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,10 +251,10 @@ This style guide is mostly based on the standards that are currently prevalent i | |
<Foo bar="bar" /> | ||
|
||
// bad | ||
<Foo style={{ left: "20px" }} /> | ||
<Foo className='bad example' /> | ||
|
||
// good | ||
<Foo style={{ left: '20px' }} /> | ||
<Foo className="good example" /> | ||
Comment on lines
-254
to
+257
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. these MUST remain as "style" with an object literal; there's nothing wrong with the current examples. |
||
``` | ||
|
||
## Spacing | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems redundant