Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Refactor to nimbus #484

Merged
merged 114 commits into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from 104 commits
Commits
Show all changes
114 commits
Select commit Hold shift + click to select a range
7ec6b7d
add @irbnb/nimbus, add dotfiles, remove config files
Aug 15, 2019
c3edc41
deps: remove unneeded config deps
Aug 15, 2019
db6c6e7
v1.17.3
Aug 22, 2019
3923715
update lerna.json, package.json
Aug 22, 2019
129f0ef
deps(vx-annotation): remove unneeded build config in package.json
Aug 22, 2019
9810058
more root config changes
Aug 22, 2019
651739a
remove react/jsx-filename-extension override
Aug 22, 2019
b411ed3
build(vx-annotation): files to .jsx, remove more unneeded config, lin…
Aug 22, 2019
e8fc435
build(root, vx-annotation): Remove unused scripts
Aug 22, 2019
f618ba3
prettier(root): run on *.md
Aug 22, 2019
0d433f8
build(vx-annotation): remove devDependencies, update package files to…
Aug 22, 2019
a3a4945
build(vx-axis): remove unneeded config
Aug 22, 2019
7b86252
build(vx-axis): .js => .jsx where relevant
Aug 22, 2019
5e015cf
lint(vx-axis)
Aug 22, 2019
2e1c70c
build(vx-text): remove unneeded config
Aug 23, 2019
4cba8d0
lint(vx-text): lint and *.js => *.jsx
Aug 23, 2019
b7d5bab
build(vx-scale): remove unneeded config
Aug 23, 2019
d3263fe
lint(vx-scale)
Aug 23, 2019
d64d2df
root: remove unneeded -- in scripts
Aug 23, 2019
5b3a432
build(vx-shape): remove uneeded config
Aug 23, 2019
6a047d3
lint(vx-shape): lots of fixes
Aug 23, 2019
fd4ae24
build(vx-group): remove unneeded config
Aug 23, 2019
8bcf1ef
lint(vx-group): lint and *.js => *.jsx
Aug 23, 2019
df7b2fa
build(vx-point): remove uneeded config
Aug 23, 2019
303ee8b
lint(vx-point)
Aug 23, 2019
49aad43
build(vx-curve): remove unneeded config
Aug 23, 2019
bc1e38d
lint(vx-curve)
Aug 23, 2019
a9fb963
build(vx-chord): remove unneeded config
Aug 23, 2019
2f57788
lint(vx-chord): lint and *.js => *.jsx
Aug 23, 2019
792ebd8
build(vx-bounds): remove unneeded config
Aug 23, 2019
3f6bc6f
lint(vx-bounds)
Aug 23, 2019
27d2b2a
build(vx-boxplot): remove unneeded config
Aug 23, 2019
a6f0acf
lint(vx-boxplot)
Aug 23, 2019
a20b369
build(vx-brush): remove unneeded config
Aug 23, 2019
c746edc
lint(vx-brush)
Aug 23, 2019
57dbfa0
build(vx-legend): remove unneeded config
Aug 23, 2019
793da7f
lint(vx-legend)
Aug 23, 2019
8e72971
fix(vx-axis): fix vx-scale paths in tests
Aug 23, 2019
e481c99
build(vx-clip-path): remove unneeded config
Aug 23, 2019
5e03750
lint(vx-clip-path)
Aug 23, 2019
4be9902
fix(vx-boxplot): fix vx-scale paths in tests
Aug 23, 2019
ee2c04a
build(vx-pattern): remove unneeded config
Aug 23, 2019
7b98c52
lint(vx-patterns)
Aug 23, 2019
3226829
build(vx-responsive): remove unneeded config
Aug 23, 2019
4976a78
lint(vx-responsive)
Aug 23, 2019
3ba997d
build(vx-voronoi): remove unneeded config
Aug 23, 2019
64de3d5
lint(vx-voronoi)
Aug 23, 2019
b37055c
build(vx-marker): remove unneeded config
Aug 23, 2019
2e70421
lint(vx-marker)
Aug 23, 2019
1e69e7a
build(vx-network): remove unneeded config
Aug 23, 2019
90ae564
lint(vx-network)
Aug 23, 2019
b6b1ec8
build(vx-zoom): remove unneeded config
Aug 23, 2019
cbd8a01
lint(vx-zoom)
Aug 23, 2019
953e00f
build(vx-drag): remove unneeded config
Aug 23, 2019
9ec2a01
lint(vx-drag)
Aug 23, 2019
7dd16fc
build(vx-grid): remove unneeded config
Aug 23, 2019
e411f62
lint(vx-grid)
Aug 23, 2019
c2739f2
build(vx-event): remove unneeded config
Aug 23, 2019
770b495
build(vx-event): remove unneeded config 2
Aug 23, 2019
dc76ea3
lint(vx-event)
Aug 23, 2019
f93299a
build(vx-geo): remove unneeded config
Aug 23, 2019
a9904dd
lint(vx-geo)
Aug 23, 2019
391d955
deps(vx-geo): add back topojson-client devDep
Aug 23, 2019
8c8a507
build(vx-glyph): remove unneeded config
Aug 23, 2019
38cd3b9
lint(vx-glyph)
Aug 23, 2019
68fb7c8
build(vx-gradient): remove unneeded config
Aug 23, 2019
ced3239
lint(vx-gradient): lint and fix gross tests
Aug 23, 2019
18b9173
build(vx-mock-data): remove unneeded config
Aug 23, 2019
cef422e
lint(vx-mock-data)
Aug 23, 2019
c437e16
build(vx-heatmap): remove unneeded config
Aug 23, 2019
42b7ab0
lint(vx-heatmap)
Aug 23, 2019
8951a60
build(vx-tooltip): remove unneeded config
Aug 23, 2019
502853d
lint(vx-tooltip)
Aug 23, 2019
4dbf7f7
build(vx-hierarchy): remove unneeded config
Aug 23, 2019
654b3a6
lint(vx-hierarchy)
Aug 23, 2019
cc8ab1c
build(vx-threshold): remove unneeded config
Aug 23, 2019
55b8912
lint(vx-threshold)
Aug 23, 2019
ea840f3
build(vx-stats): remove unneeded config
Aug 23, 2019
cf4b742
lint(vx-stats)
Aug 23, 2019
e60c0a8
build(vx-vx): remove unneeded config
Aug 23, 2019
5bd941a
fix(vx-shape): *.js => *.jsx, fix tests
Aug 24, 2019
3d29612
lint: no-console: off
Aug 24, 2019
ae5f122
fix(vx-text): allow any child
Aug 24, 2019
1e21200
fix(vx-text): allow any child
Aug 24, 2019
2cf024e
fix(vx-pattern): fix Hexagons tests
Aug 24, 2019
be3c9b4
prettier(vx-shape): make tests prettier
Aug 24, 2019
6c0f1b5
root: remove core-js dep, update husky file signature
Aug 24, 2019
f2f13b6
prettier(vx-pattern)
Aug 24, 2019
79c3b2a
docs: update docs
Aug 24, 2019
13ef549
lint(scripts/docs/index)
Aug 24, 2019
98283d6
deps: use open-source nimbus #blessed
Sep 5, 2019
ddf598d
fix(vx-demo): remove unneeded dev deps and scripts
Sep 5, 2019
2b3303e
build: don't build demo
Sep 5, 2019
362b653
scripts: add build-one script
Sep 5, 2019
731d5d3
fix(vx-event): fix error when node is passed
Sep 5, 2019
3ca34f4
fix(vx-shape): fix Polygon point generator
Sep 5, 2019
36cbea7
dev-deps(root): remove more unneeded dev deps
Sep 5, 2019
93347d1
travis: use yarn, use matrix for test + lint
Sep 5, 2019
4dd008b
root: add npmrc file
Sep 6, 2019
da3237d
nimbus: update srcFolder to match vx-demo files
Sep 6, 2019
bf63a18
lint(vx-demo)
Sep 6, 2019
834f612
vx-demo: upgrade to next@9
Sep 6, 2019
ca7d001
vx-demo: move everything into src/ for nimbus
Sep 6, 2019
eff4f08
nimbus: remove srcFolder override
Sep 6, 2019
54dba62
dev: remove dev-deps included with nimbus, turn on next
Sep 6, 2019
be03a72
scripts(root): remove bootstrap script
Sep 6, 2019
6365317
more linting for next setting
Sep 6, 2019
504029c
Merge branch 'master' of github.com:hshoff/vx into chris--nimbus
Sep 6, 2019
6b1dfe5
lint(camelcase): ignore UNSAFE_* lifecycle methods
Sep 6, 2019
256cb51
fix: fix root clean script
Sep 6, 2019
279a13a
deps(nimbus): 2.0.0
Sep 11, 2019
4febeb5
dev(dotfiles): update ignore files with tsconfig.eslint.json
Sep 11, 2019
8f45d5f
lint(vx-curve): wrap test in describe block
Sep 11, 2019
f56fc69
prettier(vx-demo): format css
Sep 11, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
26 changes: 8 additions & 18 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,18 +1,8 @@
.DS_Store
node_modules
build
dist
test
rollup.config.js
vx-demo
scripts
bundle.js
test/tmp
*.log
*.cache
/.eslintcache
.next
coverage
package-lock.json
npm-shrinkwrap.json
yarn.lock
coverage/
node_modules/
public/
esm/
lib/
tmp/
dist/
*.d.ts
37 changes: 0 additions & 37 deletions .eslintrc

This file was deleted.

54 changes: 43 additions & 11 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,14 +1,46 @@
.DS_Store
node_modules
build
dist
bundle.js
test/tmp
*.DS_Store

# Logs
logs/
*.log
*.cache
/.eslintcache
.next
coverage
package-lock.json

# Cache
.bundle/
.eslintcache/
.happo/
.idea/
.next/
.npm/
.vscode/

# Directories
build/
coverage/
dist/
esm/
lib/
public/
node_modules/
tmp/

# Custom
*.min.js
*.map

# Configs (provided by Nimbus)
.babelrc
.eslintignore
.eslintrc.js
.flowconfig
.prettierignore
babel.config.js
jest.config.js
prettier.config.js
tsconfig.json
webpack.config.js

# Lock files, libs should not have lock files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM/Yarn doesn't use them when installing packages. They are meant for developers/contributors or the project though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, Jordan mentioned once that having them can hide bugs/problems in development because developers will be locked into specific versions which consumers might not have on a fresh install.

npm-shrinkwrap.json
yarn.lock
package-lock.json
yarn.lock
42 changes: 42 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
.DS_Store

# Logs
logs/
*.log

# Cache
.eslintcache/
.idea/
.npm/
.vscode/
.yarnclean

# Directories
build/
coverage/
dist/
public/
node_modules/
tmp/

# Custom
*.min.js
*.map

# Configs
.babelrc
.dockerignore
.eslintignore
.eslintrc.js
.flowconfig
.gitattributes
.gitignore
.npmrc
.prettierignore
.yarnc
babel.config.js
dangerfile.ts
jest.config.js
prettier.config.js
tsconfig.json
webpack.config.js
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
26 changes: 14 additions & 12 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
.DS_Store
node_modules
build
bundle.js
test/tmp
*.log
*.cache
/.eslintcache
.next
coverage
package-lock.json
coverage/
node_modules/
public/
esm/
lib/
tmp/
dist/
*.d.ts
lerna.json
npm-shrinkwrap.json
yarn.lock
package.json
package-lock.json
tsconfig.json
tsconfig.options.json
CHANGELOG.md
24 changes: 18 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,22 @@
git:
depth: 10
language: node_js
node_js:
- "8"
node_js: '12'
before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH=$HOME/.yarn/bin:$PATH
install:
- yarn install --ignore-engines
before_script:
- yarn run build
matrix:
fast_finish: true
jobs:
include:
- name: Test
script: yarn run jest -w 4
- name: Lint
script: yarn run lint
cache:
directories:
- node_modules
script: travis_wait 30 npm test
after_script: "cat ./coverage/lcov.info | ./node_modules/.bin/coveralls"
yarn: true
after_script: 'cat ./coverage/lcov.info | ./node_modules/.bin/coveralls'
53 changes: 36 additions & 17 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,45 +2,64 @@

## Our Pledge

In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
In the interest of fostering an open and welcoming environment, we as contributors and maintainers
pledge to making participation in our project and our community a harassment-free experience for
everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level
of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.

## Our Standards

Examples of behavior that contributes to creating a positive environment include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a professional setting
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic address, without explicit
permission
- Other conduct which could reasonably be considered inappropriate in a professional setting

## Our Responsibilities

Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
Project maintainers are responsible for clarifying the standards of acceptable behavior and are
expected to take appropriate and fair corrective action in response to any instances of unacceptable
behavior.

Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits,
code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or
to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

## Scope

This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
This Code of Conduct applies both within project spaces and in public spaces when an individual is
representing the project or its community. Examples of representing a project or community include
using an official project e-mail address, posting via an official social media account, or acting as
an appointed representative at an online or offline event. Representation of a project may be
further defined and clarified by project maintainers.

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at hi@hshoff.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting
the project team at hi@hshoff.com. The project team will review and investigate all complaints, and
will respond in a way that it deems appropriate to the circumstances. The project team is obligated
to maintain confidentiality with regard to the reporter of an incident. Further details of specific
enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face
temporary or permanent repercussions as determined by other members of the project's leadership.

## Attribution

This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at
[http://contributor-covenant.org/version/1/4][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/4/
4 changes: 2 additions & 2 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#### :boom: Breaking Changes

-
-

#### :rocket: Enhancements

Expand All @@ -12,7 +12,7 @@

#### :bug: Bug Fix

-
-

#### :house: Internal

Expand Down
Loading