Improve bkd

[airborne12]

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[github-actions]

Thank you for your contribution to Apache Doris. Here are some TODOs after submitting your PR:

1. Trigger CI Pipeline

   If your PR is ready, please reply with run buildall.
   This command will automatically trigger all CI Pipelines.

   Currently on the master branch, the following admission tests are REQUIRED:

   • License Check: Check License Header
   • Clang Formatter: Check BE code format
   • CheckStyle: Check FE code format
   • P0 Regression (Doris Regression): P0 regression test
   • P0 Regression PipelineX (Doris Regression): P0 (with pipelinex) regression test
   • P1 Regression (Doris Regression): P1 regression test
   • External Regression (Doris External Regression): External table regression test
   • FE UT (Doris FE UT): FE unit test
   • BE UT (Doris BE UT): BE unit test
   • Build Broker: Broker build
   • Build Documents: Document build
   • ShellCheck: Check Shell script format
   • clickbench-new (clickbench): Clickbench performance test
   • Build Third Party Libraries (Linux): Third-party library build (Linux)
   • Build Third Party Libraries (macOS): Third-party library build (macOS)
   • COMPILE (DORIS_COMPILE): Full compilation
   • Need_2_Approval: Require approval from at least two reviewers

   The code can only be merged after all the above pipelines have passed.
   Besides, there are some other pipelines, but they are NOT required, meaning their pass or fail does not affect PR merging.

   You can also reply with the following keywords to trigger specific pipelines individually:

   • run compile: COMPILE (DORIS_COMPILE)
   • run p0: P0 Regression
   • run p1: P1 Regression
   • run feut: FE UT
   • run beut: BE UT
   • run external: External Regression
   • run clickbench: clickbench-new
   • run pipelinex_p0: P0 Regression PipelineX
   • run arm: P0 Regression (ARM pipeline)
   • run tpch: tpch-sf100

2. Wait for Review

   Before merging the code, it requires approval from at least two reviewers, and one of them must be a Committer of Apache Doris.

3. Merge the PR

   After all pipelines and reviews are passed, a Committer will manually merge the code.

[github-actions]

clang-tidy made some suggestions

[github-actions]

warning: method 'build' can be made static [readability-convert-member-functions-to-static]

Suggested change

	Status FulltextIndexSearcherBuilder::build(const io::FileSystemSPtr& fs,
	static Status FulltextIndexSearcherBuilder::build(const io::FileSystemSPtr& fs,

[github-actions]

warning: method 'build' can be made static [readability-convert-member-functions-to-static]

Suggested change

	Status BKDIndexSearcherBuilder::build(const io::FileSystemSPtr& fs, const std::string& index_dir,
	static Status BKDIndexSearcherBuilder::build(const io::FileSystemSPtr& fs, const std::string& index_dir,

[github-actions]

warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]

Suggested change

	namespace util {
	namespace bkd {
	namespace util::bkd {

be/src/olap/rowset/segment_v2/inverted_index_cache.h:61:

- }
- } // namespace util
+ } // namespace util

[github-actions]

warning: method 'check_null_bitmap' can be made static [readability-convert-member-functions-to-static]

be/src/olap/rowset/segment_v2/inverted_index_reader.h:145:

-     void check_null_bitmap(const FulltextIndexSearcherPtr& index_searcher,
+     static void check_null_bitmap(const FulltextIndexSearcherPtr& index_searcher,

[github-actions]

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!