Enforce HTTPS (#21182)

* Enforce HTTPS
airbytehq · Jan 13, 2023 · a8a10bb · a8a10bb
1 parent 18c1776
commit a8a10bb
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 16 deletions.
diff --git a/airbyte-integrations/connectors/destination-databend/Dockerfile b/airbyte-integrations/connectors/destination-databend/Dockerfile
@@ -34,5 +34,5 @@ COPY destination_databend ./destination_databend
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.0
+LABEL io.airbyte.version=0.1.1
 LABEL io.airbyte.name=airbyte/destination-databend
diff --git a/airbyte-integrations/connectors/destination-databend/destination_databend/client.py b/airbyte-integrations/connectors/destination-databend/destination_databend/client.py
@@ -6,8 +6,7 @@
 
 
 class DatabendClient:
-    def __init__(self, protocol: str, host: str, port: int, database: str, table: str, username: str, password: str = None):
-        self.protocol = protocol
+    def __init__(self, host: str, port: int, database: str, table: str, username: str, password: str = None):
         self.host = host
         self.port = port
         self.database = database
@@ -16,6 +15,6 @@ def __init__(self, protocol: str, host: str, port: int, database: str, table: st
         self.password = password
 
     def open(self):
-        handle = connector.connect(f"{self.protocol}://{self.username}:{self.password}@{self.host}:{self.port}").cursor()
+        handle = connector.connect(f"https://{self.username}:{self.password}@{self.host}:{self.port}").cursor()
 
         return handle
diff --git a/airbyte-integrations/connectors/destination-databend/destination_databend/spec.json b/airbyte-integrations/connectors/destination-databend/destination_databend/spec.json
@@ -24,16 +24,6 @@
         "type" : "string",
         "order" : 0
       },
-      "protocol" : {
-        "title" : "Protocol",
-        "description" : "Protocol of the host.",
-        "type" : "string",
-        "examples" : [
-          "https"
-        ],
-        "default" : "https",
-        "order" : 1
-      },
       "port" : {
         "title" : "Port",
         "description" : "Port of the database.",

diff --git a/airbyte-integrations/connectors/destination-databend/unit_tests/test_databend_destination.py b/airbyte-integrations/connectors/destination-databend/unit_tests/test_databend_destination.py
@@ -32,7 +32,6 @@ def config() -> Dict[str, str]:
         "username": "root",
         "password": "root",
         "host": "localhost",
-        "protocol": "http",
         "port": 8081,
         "table": "default",
     }

diff --git a/docs/integrations/destinations/databend.md b/docs/integrations/destinations/databend.md
@@ -51,4 +51,9 @@ You should now have all the requirements needed to configure Databend as a desti
 
 
 ## Changelog
-######TODO: more info
+
+| Version | Date       | Pull Request                                             | Subject                                  |
+|:--------|:-----------|:---------------------------------------------------------|:-----------------------------------------|
+| 0.1.1   | 2022-01-09 | [21182](https://github.com/airbytehq/airbyte/pull/21182)   | Remove protocol option and enforce HTTPS |
+| 0.1.0   | 2022-01-09 | [20909](https://github.com/airbytehq/airbyte/pull/20909)   | Destination Databend                     |
+