Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce HTTPS #21182

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Enforce HTTPS #21182

merged 2 commits into from
Jan 11, 2023

Conversation

grishick
Copy link
Contributor

@grishick grishick commented Jan 10, 2023 •
edited
Loading

What

Remove protocol option from databend spec and enforce HTTPS, so that we can add this connector to Airbyte Cloud

@grishick grishick force-pushed the greg/enforce-https-databend branch from de60e54 to 38dc47c Compare January 10, 2023 01:11
@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 10, 2023
@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023 •
edited by github-actions bot
Loading

/test connector=connectors/destination-databend

🕑 connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/3879392923
✅ connectors/destination-databend https://github.com/airbytehq/airbyte/actions/runs/3879392923
Python tests coverage:

Name                                  Stmts   Miss  Cover
---------------------------------------------------------
destination_databend/client.py           12      0   100%
destination_databend/__init__.py          2      0   100%
destination_databend/destination.py      43      2    95%
destination_databend/writer.py           48      5    90%
---------------------------------------------------------
TOTAL                                   105      7    93%

Build Passed

Test summary info:

All Passed

@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-databend

🕑 Publishing the following connectors:
connectors/destination-databend
https://github.com/airbytehq/airbyte/actions/runs/3887533303


Connector Did it publish? Were definitions generated?
connectors/destination-databend ❌ ❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grishick
Copy link
Contributor Author

grishick commented Jan 10, 2023 •
edited by github-actions bot
Loading

/publish connector=connectors/destination-databend

🕑 Publishing the following connectors:
connectors/destination-databend
https://github.com/airbytehq/airbyte/actions/runs/3888127878


Connector Did it publish? Were definitions generated?
connectors/destination-databend ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 23:39 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets January 10, 2023 23:39 — with GitHub Actions Inactive
@grishick grishick force-pushed the greg/enforce-https-databend branch from f069188 to 402d898 Compare January 11, 2023 00:00
@grishick grishick merged commit 8398e64 into master Jan 11, 2023
@grishick grishick deleted the greg/enforce-https-databend branch January 11, 2023 00:24
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Jan 12, 2023
Merged
jbfbell pushed a commit that referenced this pull request Jan 13, 2023
@grishick @jbfbell
Enforce HTTPS (#21182)
a8a10bb 
* Enforce HTTPS
@erohmensing erohmensing mentioned this pull request Feb 21, 2023
Merged
@natalyjazzviolin natalyjazzviolin mentioned this pull request Feb 24, 2023
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalyjazzviolin natalyjazzviolin natalyjazzviolin approved these changes

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/databend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grishick @natalyjazzviolin @marcosmarxm @octavia-squidington-iii @octavia-squidington-iv