Skip to content

Commit

Permalink
🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks (#24161)
Browse files Browse the repository at this point in the history
* fixed issue with the org id not being an integer and deleted duplicate streams

* bumped version to 0.1.1

* Update source_definitions.yaml

* Update acceptance-test-config.yml

* Update linkedin-pages.md

* black formatting for python

* fix tests

* update acceptance test file

* change break spec - backward compt.

* fix changelog

* auto-bump connector version

---------

Co-authored-by: Tino Merl <tino.merl@park-sieben.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: Vincent Koc <25068+koconder@users.noreply.github.com>
Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
6 people authored and erohmensing committed Mar 22, 2023
1 parent 5cc1269 commit d95de59
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@
- name: LinkedIn Pages
sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3
dockerRepository: airbyte/source-linkedin-pages
dockerImageTag: 0.1.0
dockerImageTag: 1.0.0
documentationUrl: https://docs.airbyte.com/integrations/sources/linkedin-pages
icon: linkedin.svg
sourceType: api
Expand Down
4 changes: 2 additions & 2 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7894,7 +7894,7 @@
- - "client_secret"
oauthFlowOutputParameters:
- - "refresh_token"
- dockerImage: "airbyte/source-linkedin-pages:0.1.0"
- dockerImage: "airbyte/source-linkedin-pages:1.0.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/linkedin-pages/"
connectionSpecification:
Expand All @@ -7907,7 +7907,7 @@
properties:
org_id:
title: "Organization ID"
type: "integer"
type: "string"
airbyte_secret: true
description: "Specify the Organization ID"
examples:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_linkedin_pages ./source_linkedin_pages
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=1.0.0
LABEL io.airbyte.name=airbyte/source-linkedin-pages
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
# See [Connector Acceptance Tests](https://docs.airbyte.com/connector-development/testing-connectors/connector-acceptance-tests-reference)
# for more information about how to configure these tests
connector_image: airbyte/source-linkedin-pages:dev
tests:
test_strictness_level: low
acceptance_tests:
spec:
- spec_path: "source_linkedin_pages/spec.json"
tests:
- spec_path: "source_linkedin_pages/spec.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.0"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: "0.1.0"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"org_id": 12345678,
"org_id": "12345678",
"credentials": {
"auth_method": "access_token",
"access_token": "wrong_token_sra6ibiw0ZWEdMnC0ZizeD1gLRQP6u1pkQl"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"org_id": 12345678,
"org_id": "12345678",
"credentials": {
"auth_method": "access_token",
"access_token": "example_token_string123"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"properties": {
"org_id": {
"title": "Organization ID",
"type": "integer",
"type": "string",
"airbyte_secret": true,
"description": "Specify the Organization ID",
"examples": ["123456789"]
Expand Down
2 changes: 1 addition & 1 deletion connectors.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
| **Lemlist** | x | Source | airbyte/source-lemlist:0.1.1 | alpha | [link](https://docs.airbyte.com/integrations/sources/lemlist) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lemlist) | <small>`789f8e7a-2d28-11ec-8d3d-0242ac130003`</small> |
| **Lever Hiring** | <img alt="Lever Hiring icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/leverhiring.svg" height="30" height="30"/> | Source | airbyte/source-lever-hiring:0.1.3 | alpha | [link](https://docs.airbyte.com/integrations/sources/lever-hiring) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lever-hiring) | <small>`3981c999-bd7d-4afc-849b-e53dea90c948`</small> |
| **LinkedIn Ads** | <img alt="LinkedIn Ads icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/linkedin.svg" height="30" height="30"/> | Source | airbyte/source-linkedin-ads:0.1.15 | generally_available | [link](https://docs.airbyte.com/integrations/sources/linkedin-ads) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-ads) | <small>`137ece28-5434-455c-8f34-69dc3782f451`</small> |
| **LinkedIn Pages** | <img alt="LinkedIn Pages icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/linkedin.svg" height="30" height="30"/> | Source | airbyte/source-linkedin-pages:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | <small>`af54297c-e8f8-4d63-a00d-a94695acc9d3`</small> |
| **LinkedIn Pages** | <img alt="LinkedIn Pages icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/linkedin.svg" height="30" height="30"/> | Source | airbyte/source-linkedin-pages:1.0.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/linkedin-pages) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linkedin-pages) | <small>`af54297c-e8f8-4d63-a00d-a94695acc9d3`</small> |
| **Linnworks** | <img alt="Linnworks icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/linnworks.svg" height="30" height="30"/> | Source | airbyte/source-linnworks:0.1.5 | alpha | [link](https://docs.airbyte.com/integrations/sources/linnworks) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-linnworks) | <small>`7b86879e-26c5-4ef6-a5ce-2be5c7b46d1e`</small> |
| **Lokalise** | <img alt="Lokalise icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/lokalise.svg" height="30" height="30"/> | Source | airbyte/source-lokalise:0.1.0 | alpha | [link](https://docs.airbyte.com/integrations/sources/lokalise) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-lokalise) | <small>`45e0b135-615c-40ac-b38e-e65b0944197f`</small> |
| **Looker** | <img alt="Looker icon" src="https://raw.githubusercontent.com/airbytehq/airbyte/master/airbyte-config/init/src/main/resources/icons/looker.svg" height="30" height="30"/> | Source | airbyte/source-looker:0.2.8 | alpha | [link](https://docs.airbyte.com/integrations/sources/looker) | [code](https://github.com/airbytehq/airbyte/tree/master/airbyte-integrations/connectors/source-looker) | <small>`00405b19-9768-4e0c-b1ae-9fc2ee2b2a8c`</small> |
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/linkedin-pages.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,5 @@ The source LinkedIn Pages can use either the `client_id`, `client_secret` and `r

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :--------------------------------------------------------- |
| 1.0.0 | 2023-03-16 | [18967](https://github.com/airbytehq/airbyte/pull/18967) | Fixed failing connection checks |
| 0.1.0 | 2022-08-11 | [13098](https://github.com/airbytehq/airbyte/pull/13098) | Initial Release |

0 comments on commit d95de59

Please sign in to comment.