Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks #24161

Merged
merged 20 commits into from
Mar 16, 2023
Merged

🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks #24161

merged 20 commits into from
Mar 16, 2023

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Connector version is set to 0.0.1
    • Dockerfile has version 0.0.1
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)

  • Secrets in the connector's spec are annotated with airbyte_secret

  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.

  • Code reviews completed

  • Connector version has been incremented

  • Documentation updated

    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example

  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

tinomerl and others added 20 commits November 4, 2022 13:39
@tinomerl
fixed issue with the org id not being an integer and deleted duplicat…
68b16eb 
…e streams
@tinomerl
bumped version to 0.1.1
7dad80e
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
8f0038b 
…ests
@vincentkoc
Update source_definitions.yaml
8d90b4d
@vincentkoc
Update acceptance-test-config.yml
bf1450b
@vincentkoc
Update linkedin-pages.md
4518d71
@vincentkoc
black formatting for python
49d1ac5
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
6011c72 
…ests
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
1f5f95f 
…ests
@sajarin
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
1706dd2 
…ests
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
6d7ee56 
…ests
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
26c4d18 
…ests
@vincentkoc
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
9b3154b 
…ests
@marcosmarxm
fix tests
ddddf4b
@marcosmarxm
merge master
363e024
@marcosmarxm
update acceptance test file
462f2f3
@marcosmarxm
Merge branch 'master' into tinomerl/15986-linkedin-pages-connection-t…
7ecdadd 
…ests
@marcosmarxm
change break spec - backward compt.
d5b5eaf
@marcosmarxm
fix changelog
fa37036
@octavia-squidington-iii
auto-bump connector version
aedafc3
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-pages labels Mar 16, 2023
@marcosmarxm marcosmarxm changed the title Marcos/test pr 18967 2 🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks Mar 16, 2023
@marcosmarxm marcosmarxm requested review from erohmensing, sajarin and a team March 16, 2023 19:12
erohmensing
erohmensing approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. No need to loop in TCS since this connector is not in cloud yet!

airbyte-config/init/src/main/resources/seed/source_definitions.yaml
@@ -1077,7 +1077,7 @@
- name: LinkedIn Pages
sourceDefinitionId: af54297c-e8f8-4d63-a00d-a94695acc9d3
dockerRepository: airbyte/source-linkedin-pages
dockerImageTag: 0.1.0
dockerImageTag: 1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major bump bc we changed the format of something in the spec, so old specs will be invalid 👍🏻

@marcosmarxm marcosmarxm merged commit 0391c0b into master Mar 16, 2023
@marcosmarxm marcosmarxm deleted the marcos/test-pr-18967-2 branch March 16, 2023 19:43
@marcosmarxm marcosmarxm mentioned this pull request Mar 16, 2023
Closed
37 tasks
adriennevermorel pushed a commit to adriennevermorel/airbyte that referenced this pull request Mar 17, 2023
@marcosmarxm @tinomerl
@vincentkoc @sajarin @octavia-squidington-iii @adriennevermorel
🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks (airbyteh…
64736f7 
…q#24161)

* fixed issue with the org id not being an integer and deleted duplicate streams

* bumped version to 0.1.1

* Update source_definitions.yaml

* Update acceptance-test-config.yml

* Update linkedin-pages.md

* black formatting for python

* fix tests

* update acceptance test file

* change break spec - backward compt.

* fix changelog

* auto-bump connector version

---------

Co-authored-by: Tino Merl <tino.merl@park-sieben.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: Vincent Koc <25068+koconder@users.noreply.github.com>
Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@vincentkoc vincentkoc self-assigned this Mar 17, 2023
@tinomerl tinomerl mentioned this pull request Mar 21, 2023
Closed
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@marcosmarxm @tinomerl
@vincentkoc @sajarin @octavia-squidington-iii @erohmensing
🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks (#24161)
742a52b 
* fixed issue with the org id not being an integer and deleted duplicate streams

* bumped version to 0.1.1

* Update source_definitions.yaml

* Update acceptance-test-config.yml

* Update linkedin-pages.md

* black formatting for python

* fix tests

* update acceptance test file

* change break spec - backward compt.

* fix changelog

* auto-bump connector version

---------

Co-authored-by: Tino Merl <tino.merl@park-sieben.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: Vincent Koc <25068+koconder@users.noreply.github.com>
Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
@marcosmarxm @tinomerl
@vincentkoc @sajarin @octavia-squidington-iii @erohmensing
🐛 🚨🚨 Source LinkedIn Pages: fixed failing connection checks (#24161)
d95de59 
* fixed issue with the org id not being an integer and deleted duplicate streams

* bumped version to 0.1.1

* Update source_definitions.yaml

* Update acceptance-test-config.yml

* Update linkedin-pages.md

* black formatting for python

* fix tests

* update acceptance test file

* change break spec - backward compt.

* fix changelog

* auto-bump connector version

---------

Co-authored-by: Tino Merl <tino.merl@park-sieben.com>
Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
Co-authored-by: Vincent Koc <25068+koconder@users.noreply.github.com>
Co-authored-by: Sajarin <sajarindider@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

@sajarin sajarin Awaiting requested review from sajarin

Assignees

@vincentkoc vincentkoc

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/linkedin-pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcosmarxm @erohmensing @vincentkoc @octavia-squidington-iii @tinomerl @sajarin