Skip to content

Commit

Permalink
Fix: Tutorial config-based invalid keywords #20071 (#20078)
Browse files Browse the repository at this point in the history
* Update 5-incremental-reads.md in response of Issue #20047

Added the suggested solution from issuer.

* Updated 5-incremental-reads.md #2

Appended the suggested +00:00 into another occurence. Datetime format now corresponds to standards defined in ISO-8601.

* Fix: Low Code Connector tutorial yaml #20071
  • Loading branch information
juweins authored Dec 8, 2022
1 parent 559cb63 commit dc71194
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* [jonathan-duval](https://github.com/jonathan-duval)
* [jonstacks](https://github.com/jonstacks)
* [jrhizor](https://github.com/jrhizor)
* [juweins](https://github.com/juweins)
* [keu](https://github.com/keu)
* [lazebnyi](https://github.com/lazebnyi)
* [lizdeika](https://github.com/lizdeika)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Let's populate the specification (`spec`) and the configuration (`secrets/config

```yaml
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down Expand Up @@ -170,8 +170,8 @@ check:
stream_names:
- "rates"
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ First we'll update the spec block in `source_exchange_rates_tutorial/exchange_ra

```yaml
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down Expand Up @@ -103,7 +103,7 @@ definitions:
datetime_format: "%Y-%m-%d"
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
datetime_format: "%Y-%m-%d"
cursor_field: "{{ options['stream_cursor_field'] }}"
Expand Down Expand Up @@ -181,7 +181,7 @@ definitions:
datetime_format: "%Y-%m-%d"
end_datetime:
datetime: "{{ now_utc() }}"
datetime_format: "%Y-%m-%d %H:%M:%S.%f"
datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00"
step: "1d"
datetime_format: "%Y-%m-%d"
cursor_field: "{{ options['stream_cursor_field'] }}"
Expand Down Expand Up @@ -210,8 +210,8 @@ check:
stream_names:
- "rates"
spec:
documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connectionSpecification:
documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi
connection_specification:
$schema: http://json-schema.org/draft-07/schema#
title: exchangeratesapi.io Source Spec
type: object
Expand Down

0 comments on commit dc71194

Please sign in to comment.