Fix: Tutorial config-based invalid keywords #20071 #20078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the suggested solution from issuer.
Appended the suggested +00:00 into another occurence. Datetime format now corresponds to standards defined in ISO-8601.
octavia-squidington-iv
added
area/documentation
marcosmarxm
requested changes
Dec 6, 2022
Comment on lines
+14
to
+15
| documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi | ||
| connection_specification: |
There was a problem hiding this comment.
Why are you changing this? It doesn't look correct.
There was a problem hiding this comment.
I came accross this error by validating issue #20047 . Strictly following the tutorial example, both keywords in the yaml snippets seem to be incorrect. Changing them to the proposed naming resolves the error.
There was a problem hiding this comment.
This is issue has been stated in #18663
There was a problem hiding this comment.
Sorry I missed one update from low-code CDK https://github.com/airbytehq/airbyte/pull/18411/files#r1003903362
marcosmarxm
approved these changes
Dec 7, 2022
brianjlai
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The yaml reference files in the tutorial for config-based connectors provided wrong keywords. Therefore, a user could not follow the example properly.
How
Adjusted the error-leading keywords on all occurences in this tutorial:
This PR also includes the related Issue #20047 , which also gets resolved.
The PR will also resolve #18663. (Duplicate)
🚨 User Impact 🚨
Minor.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
### Community member or AirbyterREADME.mdAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
Tests
Manually worked through the tutorial to ensure correctness.
Comment from Contributor
I am not able to rename commit 0f35da5 to reference #20047 instead of misleading issue number. Maybe you can fix this.