Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Marketo: enable high test strictness level in SAT #19055

Closed
alafanechere opened this issue Nov 7, 2022 · 1 comment · Fixed by #21790 or #21947
Closed

Source Marketo: enable high test strictness level in SAT #19055

alafanechere opened this issue Nov 7, 2022 · 1 comment · Fixed by #21790 or #21947
Assignees
@lazebnyi
Labels
area/connectors Connector related issues team/connectors-python test-strictness-level type/enhancement New feature or request

Comments

@alafanechere
Copy link
Contributor

What

A test_strictness_level field was introduced to Source Acceptance Tests (SAT).
Marketo is a generally_available connector, we want it to have a high test strictness level.

This will help:

  • maximize the SAT coverage on this connector.
  • document its potential weaknesses in term of test coverage.

How

  1. Migrate the existing acceptance-test-config.yml file to the latest configuration format. (See instructions here)
  2. Enable high test strictness level in acceptance-test-config.yml. (See instructions here)
  3. Commit changes on acceptance-test-config.yml and open a PR.
  4. Run SAT with the /test command on the branch.
  5. If tests are failing please fix the failing test or use bypass_reason fields to explain why a specific test can't be run.
@davydov-d davydov-d self-assigned this Jan 16, 2023
@igrankova igrankova mentioned this issue Jan 17, 2023
Closed
davydov-d added a commit that referenced this issue Jan 24, 2023
@davydov-d
#19055 source marketo: set high test strictness level
bd25ad7
@davydov-d davydov-d mentioned this issue Jan 24, 2023
Merged
davydov-d added a commit that referenced this issue Jan 25, 2023
@davydov-d
#19055 source marketo: increase incremental test timeout
2a60aca
davydov-d added a commit that referenced this issue Jan 25, 2023
@davydov-d
#19055 source Marketo: fix stream schemas
f36ce29
davydov-d added a commit that referenced this issue Jan 25, 2023
@davydov-d
#19055 source marketoL fix unit test
42d9ab7
@davydov-d davydov-d assigned lazebnyi and unassigned davydov-d Jan 26, 2023
@davydov-d
Copy link
Collaborator

davydov-d commented Jan 26, 2023 •
edited
Loading

@lazebnyi it seems like one data item has changed in the Programs stream.
https://github.com/airbytehq/airbyte/actions/runs/4006858817/jobs/6878964393

upd. this PR has to be rolled out in cooperation with TCS because it contains a schema change

@davydov-d davydov-d linked a pull request Jan 26, 2023 that will close this issue
Source Marketo: set high test strictness level #21790
Merged
lazebnyi added a commit that referenced this issue Jan 26, 2023
@davydov-d @lazebnyi
Source Marketo: set high test strictness level (#21790)
34d43cc 
* #19055 source marketo: set high test strictness level

* #19055 source marketo: increase incremental test timeout

* #19055 source Marketo: fix stream schemas

* #19055 source marketoL fix unit test

* Updated expected records

* Updated expected records

Co-authored-by: Serhii Lazebnyi <serhii.lazebnyi@globallogic.com>
@lazebnyi lazebnyi mentioned this issue Jan 26, 2023
Merged
@lazebnyi lazebnyi reopened this Jan 27, 2023
@lazebnyi lazebnyi linked a pull request Jan 27, 2023 that will close this issue
Source Marketo: set high test strictness level #21947
Merged
lazebnyi added a commit that referenced this issue Jan 31, 2023
@lazebnyi @davydov-d @octavia-squidington-iii
Source Marketo: set high test strictness level (#21947)
92c1a23 
* #19055 source marketo: set high test strictness level

* #19055 source marketo: increase incremental test timeout

* #19055 source Marketo: fix stream schemas

* #19055 source marketoL fix unit test

* Updated expected records

* Updated expected records

* auto-bump connector version

---------

Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazebnyi lazebnyi

Labels
area/connectors Connector related issues team/connectors-python test-strictness-level type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@alafanechere @davydov-d @lazebnyi