Source Marketo: set high test strictness level #21790

davydov-d · 2023-01-24T12:15:57Z

What

#19055

How

Modify full_refresh catalog
Modify incremental catalog
Add expected records
Refactor acceptance test config

davydov-d · 2023-01-24T12:16:31Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3996083648

davydov-d · 2023-01-24T14:50:51Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/3997401966

davydov-d · 2023-01-24T15:00:41Z

airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml

+      - config_path: "secrets/config.json"
+        expect_records:
+          path: "integration_tests/expected_records.jsonl"
+        empty_streams:


@igrankova managed to populate 29 streams, but another 23 streams can not be populated without leads/customers/etc interaction

evantahler

👍 looking for PII

evantahler · 2023-01-25T00:19:03Z

airbyte-integrations/connectors/source-marketo/acceptance-test-config.yml

+          - name: "activities_addto_opportunity"
+            bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction"
+          - name: "activities_open_email"
+            bypass_reason: "Marketo does not provide a way to populate this stream without outside interaction"


evantahler · 2023-01-25T00:20:28Z

airbyte-integrations/connectors/source-marketo/integration_tests/expected_records.jsonl

+{"stream": "leads", "data": {"company": "Test Company Org 2", "site": null, "billingStreet": null, "billingCity": null, "billingState": null, "billingCountry": null, "billingPostalCode": null, "website": null, "mainPhone": null, "annualRevenue": null, "numberOfEmployees": null, "industry": null, "sicCode": null, "mktoCompanyNotes": null, "externalCompanyId": null, "id": 895, "mktoName": "Test 2", "personType": "contact", "mktoIsPartner": false, "isLead": true, "mktoIsCustomer": false, "isAnonymous": false, "salutation": null, "firstName": "Test", "middleName": null, "lastName": "2", "email": "name5@example.com", "phone": null, "mobilePhone": null, "fax": null, "title": null, "contactCompany": "94", "dateOfBirth": null, "address": null, "city": null, "state": null, "country": null, "postalCode": null, "personTimeZone": null, "originalSourceType": "New lead", "originalSourceInfo": null, "registrationSourceType": "New lead", "registrationSourceInfo": null, "originalSearchEngine": null, "originalSearchPhrase": null, "originalReferrer": null, "emailInvalid": false, "emailInvalidCause": null, "unsubscribed": false, "unsubscribedReason": null, "doNotCall": false, "mktoDoNotCallCause": null, "doNotCallReason": null, "marketingSuspended": false, "marketingSuspendedCause": null, "blackListed": false, "blackListedCause": null, "mktoPersonNotes": null, "anonymousIP": null, "inferredCompany": null, "inferredCountry": null, "inferredCity": null, "inferredStateRegion": null, "inferredPostalCode": null, "inferredMetropolitanArea": null, "inferredPhoneAreaCode": null, "emailSuspended": null, "emailSuspendedCause": null, "emailSuspendedAt": null, "department": null, "createdAt": "2023-01-20T11:56:00Z", "updatedAt": "2023-01-20T11:56:00Z", "cookies": null, "externalSalesPersonId": null, "leadPerson": "895", "leadRole": null, "leadSource": null, "leadStatus": null, "leadScore": null, "urgency": null, "priority": null, "relativeScore": null, "relativeUrgency": null, "rating": null, "personPrimaryLeadInterest": "895", "leadPartitionId": "1", "leadRevenueCycleModelId": null, "leadRevenueStageId": null, "acquisitionProgramId": null, "mktoAcquisitionDate": null}, "emitted_at": 1674502167297}
+{"stream": "leads", "data": {"company": "Test Company Org 5", "site": null, "billingStreet": null, "billingCity": null, "billingState": null, "billingCountry": null, "billingPostalCode": null, "website": null, "mainPhone": null, "annualRevenue": null, "numberOfEmployees": null, "industry": null, "sicCode": null, "mktoCompanyNotes": null, "externalCompanyId": null, "id": 897, "mktoName": "Test test", "personType": "contact", "mktoIsPartner": false, "isLead": true, "mktoIsCustomer": false, "isAnonymous": false, "salutation": null, "firstName": "Test", "middleName": null, "lastName": "test", "email": "name8@example.com", "phone": null, "mobilePhone": null, "fax": null, "title": null, "contactCompany": "95", "dateOfBirth": null, "address": null, "city": null, "state": null, "country": null, "postalCode": null, "personTimeZone": null, "originalSourceType": "New lead", "originalSourceInfo": null, "registrationSourceType": "New lead", "registrationSourceInfo": null, "originalSearchEngine": null, "originalSearchPhrase": null, "originalReferrer": null, "emailInvalid": false, "emailInvalidCause": null, "unsubscribed": false, "unsubscribedReason": null, "doNotCall": false, "mktoDoNotCallCause": null, "doNotCallReason": null, "marketingSuspended": false, "marketingSuspendedCause": null, "blackListed": false, "blackListedCause": null, "mktoPersonNotes": null, "anonymousIP": null, "inferredCompany": null, "inferredCountry": null, "inferredCity": null, "inferredStateRegion": null, "inferredPostalCode": null, "inferredMetropolitanArea": null, "inferredPhoneAreaCode": null, "emailSuspended": null, "emailSuspendedCause": null, "emailSuspendedAt": null, "department": null, "createdAt": "2023-01-23T08:09:55Z", "updatedAt": "2023-01-23T08:09:56Z", "cookies": null, "externalSalesPersonId": null, "leadPerson": "897", "leadRole": null, "leadSource": null, "leadStatus": null, "leadScore": null, "urgency": null, "priority": null, "relativeScore": null, "relativeUrgency": null, "rating": null, "personPrimaryLeadInterest": "897", "leadPartitionId": "1", "leadRevenueCycleModelId": null, "leadRevenueStageId": null, "acquisitionProgramId": null, "mktoAcquisitionDate": null}, "emitted_at": 1674502167299}
+{"stream": "leads", "data": {"company": "Test Company Org 5", "site": null, "billingStreet": null, "billingCity": null, "billingState": null, "billingCountry": null, "billingPostalCode": null, "website": null, "mainPhone": null, "annualRevenue": null, "numberOfEmployees": null, "industry": null, "sicCode": null, "mktoCompanyNotes": null, "externalCompanyId": null, "id": 898, "mktoName": "Person 1 Person 1", "personType": "contact", "mktoIsPartner": false, "isLead": true, "mktoIsCustomer": false, "isAnonymous": false, "salutation": null, "firstName": "Person 1", "middleName": null, "lastName": "Person 1", "email": "name100@example.com", "phone": null, "mobilePhone": null, "fax": null, "title": null, "contactCompany": "96", "dateOfBirth": null, "address": null, "city": null, "state": null, "country": null, "postalCode": null, "personTimeZone": null, "originalSourceType": "New lead", "originalSourceInfo": null, "registrationSourceType": "New lead", "registrationSourceInfo": null, "originalSearchEngine": null, "originalSearchPhrase": null, "originalReferrer": null, "emailInvalid": false, "emailInvalidCause": null, "unsubscribed": false, "unsubscribedReason": null, "doNotCall": false, "mktoDoNotCallCause": null, "doNotCallReason": null, "marketingSuspended": false, "marketingSuspendedCause": null, "blackListed": false, "blackListedCause": null, "mktoPersonNotes": null, "anonymousIP": null, "inferredCompany": null, "inferredCountry": null, "inferredCity": null, "inferredStateRegion": null, "inferredPostalCode": null, "inferredMetropolitanArea": null, "inferredPhoneAreaCode": null, "emailSuspended": null, "emailSuspendedCause": null, "emailSuspendedAt": null, "department": null, "createdAt": "2023-01-23T08:20:01Z", "updatedAt": "2023-01-23T08:20:01Z", "cookies": null, "externalSalesPersonId": null, "leadPerson": "898", "leadRole": null, "leadSource": null, "leadStatus": null, "leadScore": null, "urgency": null, "priority": null, "relativeScore": null, "relativeUrgency": null, "rating": null, "personPrimaryLeadInterest": "898", "leadPartitionId": "1", "leadRevenueCycleModelId": null, "leadRevenueStageId": null, "acquisitionProgramId": null, "mktoAcquisitionDate": null}, "emitted_at": 1674502167300}


👍 fake email addresses

evantahler · 2023-01-25T00:20:58Z

airbyte-integrations/connectors/source-marketo/integration_tests/expected_records.jsonl

+{"stream": "activities_delete_lead", "data": {"marketoGUID": "2280", "leadId": 849, "activityDate": "2023-01-23T08:36:22Z", "activityTypeId": 37, "campaignId": 1162, "primaryAttributeValueId": "849", "primaryAttributeValue": "Kataldar-70"}, "emitted_at": 1674506602584}
+{"stream": "activities_delete_lead", "data": {"marketoGUID": "2281", "leadId": 852, "activityDate": "2023-01-23T08:36:22Z", "activityTypeId": 37, "campaignId": 1162, "primaryAttributeValueId": "852", "primaryAttributeValue": "Kataldar-74"}, "emitted_at": 1674506602585}
+{"stream": "activities_email_bounced", "data": {"marketoGUID": "2273", "leadId": 880, "activityDate": "2023-01-23T08:25:26Z", "activityTypeId": 8, "campaignId": 1159, "primaryAttributeValueId": "1009", "primaryAttributeValue": "Test Nurture.integration-tgest@airbyte.io", "campaign_run_id": 112, "category": "2", "email": "alastor@moody.com", "details": "550 5.4.1 Recipient address rejected: Access denied. AS(201806281) [SN1NAM02FT0043.eop-nam02.prod.protection.outlook.com]", "subcategory": "2003", "step_id": 489, "choice_number": 623}, "emitted_at": 1674507111307}


👍 fake emails (harry potter)

davydov-d · 2023-01-25T08:49:10Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4004248501

davydov-d · 2023-01-25T13:55:23Z

/test connector=connectors/source-marketo

davydov-d · 2023-01-25T14:05:03Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4006680709

davydov-d · 2023-01-25T14:25:05Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4006858817

lazebnyi · 2023-01-26T17:29:30Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4017624630

lazebnyi · 2023-01-26T19:25:04Z

/test connector=connectors/source-marketo

🕑 connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4018470532
✅ connectors/source-marketo https://github.com/airbytehq/airbyte/actions/runs/4018470532
Python tests coverage:

Name                         Stmts   Miss  Cover
------------------------------------------------
source_marketo/__init__.py       2      0   100%
source_marketo/utils.py         33      1    97%
source_marketo/source.py       273     30    89%
------------------------------------------------
TOTAL                          308     31    90%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       141      5    96%   87, 93, 239, 243-244
	 source_acceptance_test/conftest.py                     211     95    55%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-285, 293-306, 311-317, 324-335, 342-358
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              402    115    71%   53, 58, 93-104, 109-116, 120-121, 125-126, 308, 346-363, 376-387, 391-396, 402, 435-440, 478-485, 528-530, 533, 598-606, 618-621, 626, 682-683, 689, 692, 728-738, 751-776
	 source_acceptance_test/tests/test_incremental.py       160     14    91%   58-65, 70-83, 246
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1609    339    79%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:94: The previous and actual specifications are identical.
================== 30 passed, 1 skipped in 5093.38s (1:24:53) ==================

This reverts commit 34d43cc.

) This reverts commit 34d43cc.

#19055 source marketo: set high test strictness level

bd25ad7

octavia-squidington-iv added area/connectors Connector related issues connectors/source/marketo labels Jan 24, 2023

davydov-d marked this pull request as draft January 24, 2023 12:16

davydov-d marked this pull request as ready for review January 24, 2023 14:57

davydov-d requested review from lazebnyi and darynaishchenko January 24, 2023 14:57

davydov-d commented Jan 24, 2023

View reviewed changes

darynaishchenko approved these changes Jan 24, 2023

View reviewed changes

lazebnyi requested a review from erohmensing January 24, 2023 22:09

lazebnyi approved these changes Jan 24, 2023

View reviewed changes

lazebnyi requested a review from evantahler January 24, 2023 22:30

evantahler approved these changes Jan 25, 2023

View reviewed changes

lazebnyi removed the request for review from erohmensing January 25, 2023 00:22

#19055 source marketo: increase incremental test timeout

2a60aca

#19055 source Marketo: fix stream schemas

f36ce29

octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Jan 25, 2023

#19055 source marketoL fix unit test

42d9ab7

davydov-d assigned lazebnyi Jan 26, 2023

davydov-d linked an issue Jan 26, 2023 that may be closed by this pull request

Source Marketo: enable high test strictness level in SAT #19055

Closed

Updated expected records

6271745

Updated expected records

019c8fb

lazebnyi merged commit 34d43cc into master Jan 26, 2023

lazebnyi deleted the ddavydov/#19055-source-marketo-high-test-strictness-level branch January 26, 2023 22:52

lazebnyi added a commit that referenced this pull request Jan 26, 2023

Revert "Source Marketo: set high test strictness level (#21790)"

1c41660

This reverts commit 34d43cc.

lazebnyi mentioned this pull request Jan 26, 2023

Revert "Source Marketo: set high test strictness level" #21945

Closed

lazebnyi restored the ddavydov/#19055-source-marketo-high-test-strictness-level branch January 26, 2023 22:54

lazebnyi mentioned this pull request Jan 26, 2023

Revert "Source Marketo: set high test strictness level" #21946

Merged

lazebnyi added a commit that referenced this pull request Jan 26, 2023

Revert "Source Marketo: set high test strictness level (#21790)" (#21946

bb0ce26

) This reverts commit 34d43cc.

lazebnyi mentioned this pull request Jan 26, 2023

Source Marketo: set high test strictness level #21947

Merged

This was referenced Jan 27, 2023

Bump Airbyte version from 0.40.29 to 0.40.30 #21954

Closed

Bump Airbyte version from 0.40.29 to 0.40.30 #21991

Closed

Bump Airbyte version from 0.40.29 to 0.40.30 #22045

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Marketo: set high test strictness level #21790

Source Marketo: set high test strictness level #21790

davydov-d commented Jan 24, 2023 •

edited

Loading

davydov-d commented Jan 24, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 24, 2023 •

edited by github-actions bot

Loading

davydov-d Jan 24, 2023

evantahler left a comment

evantahler Jan 25, 2023

evantahler Jan 25, 2023

evantahler Jan 25, 2023

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 25, 2023

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 26, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 26, 2023 •

edited by github-actions bot

Loading

Source Marketo: set high test strictness level #21790

Source Marketo: set high test strictness level #21790

Conversation

davydov-d commented Jan 24, 2023 • edited Loading

What

How

davydov-d commented Jan 24, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 24, 2023 • edited by github-actions bot Loading

davydov-d Jan 24, 2023

Choose a reason for hiding this comment

evantahler left a comment

Choose a reason for hiding this comment

evantahler Jan 25, 2023

Choose a reason for hiding this comment

evantahler Jan 25, 2023

Choose a reason for hiding this comment

evantahler Jan 25, 2023

Choose a reason for hiding this comment

davydov-d commented Jan 25, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 25, 2023

davydov-d commented Jan 25, 2023 • edited by github-actions bot Loading

davydov-d commented Jan 25, 2023 • edited by github-actions bot Loading

lazebnyi commented Jan 26, 2023 • edited by github-actions bot Loading

lazebnyi commented Jan 26, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Jan 24, 2023 •

edited

Loading

davydov-d commented Jan 24, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 24, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

davydov-d commented Jan 25, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 26, 2023 •

edited by github-actions bot

Loading

lazebnyi commented Jan 26, 2023 •

edited by github-actions bot

Loading