Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ❌ sources in connector dependency workflow #19451

Closed
erohmensing opened this issue Nov 15, 2022 · 1 comment · Fixed by #19865
Closed

Resolve ❌ sources in connector dependency workflow #19451

erohmensing opened this issue Nov 15, 2022 · 1 comment · Fixed by #19865
Assignees

Comments

@erohmensing
Copy link
Contributor

Tell us about the problem you're trying to solve

RIght now, the connector dependency workflow tells us some helpful information about dependent connectors. If there are big issues (version mismatch, missing changelog), it will un-collapse the list, so that the users will be sure to look at the issues.

In practice, because there were already big issues, the list always comes un-collapsed and since this is a regular occurence, is ignored. Since the comment is updated on every commit, even if you collapse it, it opens again, leading to the initial issue of lots of scrolling.

Describe the solution you’d like

  1. For now, make it always start collapsed.
  2. Go in and fix any ❌ issues on sources and connectors so that "the build is green", so to say. This will hopefully make it much more likely that any new ❌ issues are actually caught.
@evantahler
Copy link
Contributor

I'll be working from the list here: #19848 (comment)

@evantahler evantahler changed the title Resolve ❌ items in connector dependency workflow Resolve ❌ sources in connector dependency workflow Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants