Fix affected connectors #19865

evantahler · 2022-11-29T02:11:10Z

Now that we have an excellent Affected Connectors Report, we have been alerted to some failing connectors from the past. This PR fixes them.

Closes #19451

evantahler · 2022-11-29T02:11:43Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

-  documentationUrl: https://docs.airbyte.com/integrations/sources/presta-shop
+  documentationUrl: https://docs.airbyte.com/integrations/sources/prestashop


documentation URLs need to match the connector name exactly

evantahler · 2022-11-29T02:11:49Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

-  documentationUrl: https://docs.airbyte.com/integrations/sources/presta-shop
+  documentationUrl: https://docs.airbyte.com/integrations/sources/primetric


Wrong doc url!

Great catch! There could be more of those in there... Might be worth a [optional, hypothetical] script to validate that 🤔

evantahler · 2022-11-29T02:11:53Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

-  documentationUrl: https://docs.airbyte.com/integrations/sources/quickbooks
+  documentationUrl: https://docs.airbyte.com/integrations/sources/quickbooks-singer


documentation URLs need to match the connector name exactly

evantahler · 2022-11-29T02:12:03Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+- name: Pardot
+  sourceDefinitionId: ad15c7ba-72a7-440b-af15-b9a963dc1a8a
+  dockerRepository: airbyte/source-pardot
+  dockerImageTag: 0.1.0
+  documentationUrl: https://docs.airbyte.com/integrations/sources/pardot
+  icon: pardot.svg
+  sourceType: api
+  releaseStage: alpha


Pardot was missing from the catalog

evantahler · 2022-11-29T02:12:16Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+- name: AppsFlyer
+  sourceDefinitionId: 16447954-e6a8-4593-b140-43dea13bc457
+  dockerRepository: airbyte/source-appsflyer
+  dockerImageTag: 0.1.0
+  documentationUrl: https://docs.airbyte.com/integrations/sources/appsflyer
+  icon: appsflyer.svg
+  sourceType: api
+  releaseStage: alpha


AppsFlyer was missing from the catalog

docs/integrations/sources/appsflyer.md

docs/integrations/sources/mailgun.md

docs/integrations/sources/pardot.md

evantahler · 2022-11-29T02:13:46Z

docs/integrations/sources/tplcentral.md

@@ -1,4 +1,4 @@
-# 3PL Central
+# TPL/3PL Central


I can't figure out the actual name of this connector...

maybe t stands for "three" in tpl? In any case it looks like it might change to Extensiv-3pl or something in the future -- we should keep an eye on that.

I'd probably leave the name here. Weird initial implementation...

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

evantahler · 2022-11-29T17:44:37Z

From grooming:

For the Alpha connectors that didn't have docs until this PR, I will:

remove the 'TODO'
write a single sentence like "This is the Airbyte connector for vendor(link)" just to have something
Docs will be created in earnest when they move from Alpha to Beta.

cc @Amruta-Ranade - so there's no action needed on your side!

erohmensing

I assume we have a way of handling redirects -- we should make sure to write redirect rules for those docs pages whose links have changed in case they're linked externally anywhere

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

erohmensing · 2022-11-29T23:55:57Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

-  documentationUrl: https://docs.airbyte.com/integrations/sources/presta-shop
+  documentationUrl: https://docs.airbyte.com/integrations/sources/primetric


Great catch! There could be more of those in there... Might be worth a [optional, hypothetical] script to validate that 🤔

docs/integrations/sources/lemlist.md

docs/integrations/sources/linnworks.md

docs/integrations/sources/primetric.md

erohmensing · 2022-11-30T00:12:21Z

docs/integrations/sources/tplcentral.md

@@ -1,4 +1,4 @@
-# 3PL Central
+# TPL/3PL Central


maybe t stands for "three" in tpl? In any case it looks like it might change to Extensiv-3pl or something in the future -- we should keep an eye on that.

I'd probably leave the name here. Weird initial implementation...

erohmensing · 2022-11-30T00:19:09Z

Oh! @evantahler one more thing, would you please re-enable the old logic of auto-collapse here (lines 200-201)? Should be open if source_status_summary == "❌" else "closed" for both

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>

evantahler added 12 commits November 28, 2022 17:43

source-appsflyer

b79c88e

source-cart

af19c5c

source-chargebee

a5d4028

source-lemlist

3bf6b22

source-linnworks

8c35b61

source-mailgun

8f848d1

source-pardot

76156af

source-plaid

4092534

source-prestashop

0e4fdcd

source-quickbooks-singer

3364d0e

source-recharge

b6cd03c

source-tplcentral

cb0b001

evantahler temporarily deployed to more-secrets November 29, 2022 02:12 Inactive

evantahler commented Nov 29, 2022

View reviewed changes

evantahler requested review from Amruta-Ranade and a team November 29, 2022 02:14

remove icons that aren't real

c856033

evantahler commented Nov 29, 2022

View reviewed changes

airbyte-config/init/src/main/resources/seed/source_definitions.yaml Show resolved Hide resolved

evantahler marked this pull request as ready for review November 29, 2022 02:18

evantahler requested a review from a team as a code owner November 29, 2022 02:18

evantahler temporarily deployed to more-secrets November 29, 2022 02:19 Inactive

evantahler temporarily deployed to more-secrets November 29, 2022 21:40 Inactive

Merge branch 'master' into evan/fix-affected-connectors

ddb9237

evantahler temporarily deployed to more-secrets November 29, 2022 23:48 Inactive

erohmensing approved these changes Nov 30, 2022

View reviewed changes

Update docs/integrations/sources/primetric.md

137a53b

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>

evantahler temporarily deployed to more-secrets November 30, 2022 00:23 Inactive

evantahler requested a review from sherifnada November 30, 2022 01:41

bump readmes

4964267

evantahler temporarily deployed to more-secrets November 30, 2022 01:44 Inactive

revert ci_check_deps logic

58a642e

evantahler temporarily deployed to more-secrets November 30, 2022 01:49 Inactive

New name

2f6047f

evantahler temporarily deployed to more-secrets November 30, 2022 01:53 Inactive

sherifnada approved these changes Nov 30, 2022

View reviewed changes

Merge branch 'master' into evan/fix-affected-connectors

56defc7

evantahler temporarily deployed to more-secrets November 30, 2022 16:36 Inactive

evantahler merged commit ea58882 into master Nov 30, 2022

evantahler deleted the evan/fix-affected-connectors branch November 30, 2022 17:51

octavia-squidington-iii mentioned this pull request Nov 30, 2022

Bump Airbyte version from 0.40.22 to 0.40.23 #19941

Merged

evantahler mentioned this pull request Dec 2, 2022

SAT: Capture configuration updates from connectors' control messages #19979

Merged

erohmensing mentioned this pull request Dec 9, 2022

fix all ❌ and ⚠️ in ci_check_dependency (full TODO list) #20324

Closed

evantahler mentioned this pull request Dec 19, 2022

Fix CI Dependency Check Failures #20666

Merged

alafanechere mentioned this pull request Dec 20, 2022

ci-connector-ops: enforce connector metadata checks on connector PR #20707

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix affected connectors #19865

Fix affected connectors #19865

evantahler commented Nov 29, 2022 •

edited

Loading

evantahler Nov 29, 2022

evantahler Nov 29, 2022

erohmensing Nov 29, 2022

evantahler Nov 29, 2022

evantahler Nov 29, 2022

evantahler Nov 29, 2022

evantahler Nov 29, 2022

erohmensing Nov 30, 2022

evantahler commented Nov 29, 2022

erohmensing left a comment

erohmensing Nov 29, 2022

erohmensing Nov 30, 2022

erohmensing commented Nov 30, 2022 •

edited

Loading

		documentationUrl: https://docs.airbyte.com/integrations/sources/presta-shop
		documentationUrl: https://docs.airbyte.com/integrations/sources/prestashop

Fix affected connectors #19865

Fix affected connectors #19865

Conversation

evantahler commented Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

evantahler commented Nov 29, 2022

erohmensing left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erohmensing commented Nov 30, 2022 • edited Loading

evantahler commented Nov 29, 2022 •

edited

Loading

erohmensing commented Nov 30, 2022 •

edited

Loading