Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declarative connectors management: Extend CDK publish process to update CDK version file #22485

Closed
flash1293 opened this issue Feb 7, 2023 · 2 comments
Closed

Declarative connectors management: Extend CDK publish process to update CDK version file #22485

flash1293 opened this issue Feb 7, 2023 · 2 comments
Assignees
@maxi297
Labels
team/extensibility

Comments

@flash1293
Copy link
Contributor

flash1293 commented Feb 7, 2023 •
edited
Loading

The CDK_VERSION file containing the target cdk version for webapp and connector builder server as well as the image tag for declarative sources introduced in #22575 should be updated automatically as part of the CDK publish process.

The CDK publish action triggers another action in the platform repo to update the CDK_VERSION file:

  • Open a PR to the platform repo updating the version in the CDK_VERSION file to the new latest version
  • Ping the extensibility team on it
  • Set it on auto-merge

From here, the process works as follows:

  • The person that kicked off the CDK publish owns the PR
  • If the change is small and doesn't require adjustments to connector builder server nor webapp, it's just about making sure the build succeeds and the change is merged correctly. From here on this change can be treated like any platform change (requires a release to be available to OSS users or a deploy to be available in cloud)
  • If the change is bigger and the platform needs to be adjusted, the owner disables auto-merge and works on making the necessary changes as part of the auto-created PR.

The steps above are documented in a suitable place.

Acceptance criteria

  • Publishing the CDK will open a PR reflecting the new version in the platform (webapp, connector builder server, auto-updater)
  • The process is documented
@flash1293 flash1293 changed the title Declarative connectors management: Extend CDK publish process with creating PR to update seed file Declarative connectors management: Extend CDK publish process to update seed file Feb 7, 2023
@flash1293 flash1293 mentioned this issue Feb 8, 2023
Closed
@flash1293
Copy link
Contributor Author

FYI @maxi297 as you mentioned this on your PRD as well

@flash1293 flash1293 changed the title Declarative connectors management: Extend CDK publish process to update seed file Declarative connectors management: Extend CDK publish process to update CDK verison file Feb 20, 2023
@flash1293 flash1293 changed the title Declarative connectors management: Extend CDK publish process to update CDK verison file Declarative connectors management: Extend CDK publish process to update CDK version file Feb 20, 2023
@flash1293
Copy link
Contributor Author

Story points: 5

maxi297 added a commit that referenced this issue Mar 2, 2023
@maxi297
[ISSUE #22485] testing opening a PR after modifying one file
05ec761
maxi297 added a commit that referenced this issue Mar 2, 2023
@maxi297
[ISSUE #22485] trying to modify files
c32a089
@maxi297 maxi297 mentioned this issue Mar 2, 2023
Closed
@maxi297 maxi297 mentioned this issue Mar 2, 2023
Closed
maxi297 added a commit that referenced this issue Mar 2, 2023
@maxi297
[ISSUE #22485] enable automerge (won't work here because version is i…
1720d40 
…nvalid)
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] move to internal repo
5bcb027
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] pointing automerge to proper repository
38c492e
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] test job output to pass version
b8b7ec1
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] test unique branch name
53d466c
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] test create-pull-request output
e693c86
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] merging test workflow into real workflow
e509e5c
maxi297 added a commit that referenced this issue Mar 3, 2023
@maxi297
[ISSUE #22485] adding message on failure to create the PR
fc62c25
@maxi297 maxi297 mentioned this issue Mar 3, 2023
Merged
maxi297 added a commit that referenced this issue Mar 7, 2023
@maxi297
[ISSUE #22485] testing opening a PR after modifying one file (#23692)
3105493 
* [ISSUE #22485] testing opening a PR after modifying one file

* [ISSUE #22485] trying to modify files

* [ISSUE #22485] enable automerge (won't work here because version is invalid)

* [ISSUE #22485] move to internal repo

* [ISSUE #22485] pointing automerge to proper repository

* [ISSUE #22485] test job output to pass version

* [ISSUE #22485] test unique branch name

* [ISSUE #22485] test create-pull-request output

* [ISSUE #22485] merging test workflow into real workflow

* [ISSUE #22485] adding message on failure to create the PR
@maxi297 maxi297 closed this as completed Mar 8, 2023
danielduckworth pushed a commit to danielduckworth/airbyte that referenced this issue Mar 13, 2023
@maxi297 @danielduckworth
[ISSUE airbytehq#22485] testing opening a PR after modifying one file (…
19e3666 
…airbytehq#23692)

* [ISSUE airbytehq#22485] testing opening a PR after modifying one file

* [ISSUE airbytehq#22485] trying to modify files

* [ISSUE airbytehq#22485] enable automerge (won't work here because version is invalid)

* [ISSUE airbytehq#22485] move to internal repo

* [ISSUE airbytehq#22485] pointing automerge to proper repository

* [ISSUE airbytehq#22485] test job output to pass version

* [ISSUE airbytehq#22485] test unique branch name

* [ISSUE airbytehq#22485] test create-pull-request output

* [ISSUE airbytehq#22485] merging test workflow into real workflow

* [ISSUE airbytehq#22485] adding message on failure to create the PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxi297 maxi297

Labels
team/extensibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flash1293 @maxi297