-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector generator: Investigate build issues #35893
Comments
I have been running into the same thing with an HTTP source connector. Followed the directions as outlined in: https://docs.airbyte.com/connector-development/tutorials/cdk-tutorial-python-http/getting-started spec all appear to work correctly. Moving the generated files out of the src directory seems to solve some of the problems on the actual build side, but when that connector source is added to AirByte OSS through the web ui, it fails to discover the schema. |
@alafanechere, you're probably the closest one to that change in the first place — want to clean this up? |
Another user stumbled at this today — I'll try to get this sorted |
Stumbled onto the same issue today. We're trying to get an internal custom connector deployed and we can't get it to build atm using the proposed Dockerfile contents from the docs, neither with the |
|
…uilds it (#36428) ### What For newly generated python and low-code connectors, move sources from `src` to `source_%CONN_NAME%` so `airbyte-ci build` can pick them up correctly. Closes #35893. ### What changed? - Moved the sources from `src` - Updated package paths in `pyproject.toml` templates ### How to test? You can make a new connector with `./generate.sh` and verify that it works with Poetry and that it builds with `airbyte-ci build --name source-test` ---
After moving the connector generator over to poetry, there is some cleanup that needs to be done. This was reported by a community user, I haven't reproduced yet.
These are issues with Step 7: building/running the connector in docker
Option A: Building the docker image with airbyte-ci
airbyte-ci build
build fails withThis is likely because we have nested the generated connector into a
src
directory, but don't have handling for that inairbyte-ci build
. Moving the generated files out of the src directory into the root fixes the issue as a workaround.Option B: Building the docker image with a Dockerfile
Based on changes, the dockerfile here likely needs to be updated.
The text was updated successfully, but these errors were encountered: