connector-templates: Cleanup connector generator #36427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cleans up connector generator, specifically: - Removes java sources and destinations from plopfile - Removes singer source from plopfile - Removes generic and python (non-http) source from plopfile - Cleans up documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
postamar
reviewed
Mar 24, 2024
alafanechere
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Please make sure @marcosmarxm is aware of this change (mainly the renaming of source-http-api to source-python
marcosmarxm
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
It's more aligned with our current docs. Thanks @natikgadzhi
octavia-squidington-iii
removed
the
area/documentation
|
I think Graphite got this into master with the other one. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Follows up #36193 and actually removes singer from plopfile.
This commit cleans up connector generator, specifically:
Next steps
Now that the cleanup is done, next step is to go into
airbyte-ci/connectors/pipelines/build/and figure out how to account forsrcin templates in #35893.