Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon SP: Support (even) more API endpoints #4936

Closed
sherifnada opened this issue Jul 23, 2021 · 1 comment · Fixed by #5248
Closed

Amazon SP: Support (even) more API endpoints #4936

sherifnada opened this issue Jul 23, 2021 · 1 comment · Fixed by #5248
Assignees
Labels
area/connectors Connector related issues lang/python priority/high High priority type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

Inventory
Shipments
Vendor Inventory
Vendor Shipments
FBA Inventory
FBA Orders
FBA Shipments

@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues lang/python labels Jul 23, 2021
@sherifnada sherifnada added this to the Connectors August 6th milestone Jul 23, 2021
@sherifnada sherifnada added the priority/high High priority label Jul 23, 2021
@htrueman
Copy link
Contributor

htrueman commented Jul 27, 2021

Product Requirements & features

  1. What is the “ideal end state” for the features offered by this connector? At a minimum mention:
    a. Output schema
    All schemas are documented with swagger.
    b. Authentication
    AWS users complicated auth system, which is documented here. Already implemented in 🚀 Amazon SP: expand endpoint support #4863.
    c. Include more topics as you see fit depending on the connector (etc…)
    We may use https://github.com/saleweaver/python-amazon-sp-api lib for some code samples and inspiration.
    It is also not clear for now on how to get list Shipments records, going to research later.
  2. What is the release roadmap for this connector?
    a. Which features are absolutely necessary for the MVP release?
    First we are going to implement FBA Inventory (seems to be already implemented), FBA Orders, FBA Shipments streams. As they are records streams and easy to implement. Then Vendor Inventory, Vendor Shipments streams. Inventory and Shipments need to be researched more before implementation.
  3. Check if and how Fivetran or Stitch Data support this connector
    Fivetran does not support Amazon SP connector.
    Same for Stitchdata.

Implementation Scoping

  • Describe the pagination strategy used by the API
    It's NextToken query param in all the streams. If we add this token, then no other params are supported.
  • Describe the authentication strategy used by the API. If Oauth, go into detail about how the token can be obtained and if there are any special gotchas.
    Oauth. Auth strategy is really complex. But shortly: we need to transform, encode and subscribe initial credentials, then get access/refresh token from Amazon, then use it to auth requests. More details in docs
  • Describe how we will populate the sandbox account with data
    Now we are using our test account, but there are no actual data in most streams. Thus we need to either user some prod account (I can't use Amazon SP API (owned by cart.com) creds from LastPass, as there are no enough permissions) or fill test account with some real data.
  • How will rate limiting be handled?
    Rate limits are specified in the docs for each API type https://github.com/amzn/selling-partner-api-docs/tree/main/references These may be configured and for now our default backoff approach should be enough handle it.
  • Type of the API? (REST/SOAP/GraphQL/other)
    REST

Integration details
See guide from Amazon: https://github.com/amzn/selling-partner-api-docs/blob/main/guides/en-US/developer-guide/SellingPartnerApiDeveloperGuide.md
Google sheet connector details: https://docs.google.com/spreadsheets/d/1s-MAwI5d3eBlBOD8II_sZM7pw5FmZtAJsx1KJjVRFNU/edit#gid=1972105305

@htrueman htrueman linked a pull request Aug 3, 2021 that will close this issue
26 tasks
@keu keu changed the title Support (even) more Amazon SP API endpoints Amazon SP: Support (even) more API endpoints Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues lang/python priority/high High priority type/enhancement New feature or request
Projects
None yet
2 participants