Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Amazon SP extra endpoint support #5248

Merged
merged 54 commits into from
Sep 17, 2021

Conversation

htrueman
Copy link
Contributor

@htrueman htrueman commented Aug 6, 2021

What

Closes #4936

How

Added additional streams support.

Recommended reading order

  1. source.py
  2. streams.py
  3. Schema files

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions
  • Connector added to connector index like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions
  • Connector version bumped like described here

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

Update streams.py
…zon-sp-expand-endpoint-support

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/acceptance-test-config.yml
Add pydantic spec.
PR fixes.
Add _create_prepared_request docstring.
…zon-sp-expand-endpoint-support

# Conflicts:
#	airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/e55879a8-0ef8-4557-abcf-ab34c53ec460.json
#	airbyte-config/init/src/main/resources/seed/source_definitions.yaml
… htrueman/source-amazon-sp-extra-endpoint-support
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 6, 2021
…zon-sp-extra-endpoint-support

# Conflicts:
#	airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/configured_catalog.json
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/source.py
#	airbyte-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/streams.py
htrueman and others added 2 commits September 17, 2021 13:28
* Update check connection method

* #5796 silence printing full config when config validation fails (#5879)

* - #5796 silence printing full config when config validation fails

* fix unit tests after config validation check changes

Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com>

* Format google-search-console schemas (#6047)

* Update ads_insights.json (#5946)

fix ads_insights schema according to [facebook docs](https://developers.facebook.com/docs/marketing-api/reference/adgroup/insights/) and my own data

* Bump connectors version + update docs (#6060)

* 🐛 Source Facebook Marketing: Convert values' types according to schema types (#4978)

* Convert values' types according to schema types

* Put streams back to `configured_catalog.json`

Put back `ads_insights` and `ads_insights_age_and_gender` streams.

* Pickup changes from #5946

* Implement change request + fix previous PR

* Update schema

* Remove items_type from convert_to_schema_types()

* Bump connectors version

* add oauth to connector_base dependencies (#6064)

* use spec when persisting source configs (#6036)

* switch most usages of writing sources to using specs

* fix other usages

* fix test

* only wait on the server in the scheduler, not the worker

* fix

* rephrase sanity check and remove stdout

* 🎉 Source Stripe: Add `PaymentIntents` stream (#6004)

* Add `PaymentIntents` stream

* Update docs

* Implement change request + few updates

Split `source.py` file into `source.py` and `streams.py` files.
Update `payment_intents.json` file.

* Bump connectors version + update docs

* Add skeleton for databricks destination (#5629)

Co-authored-by: Liren Tu <tuliren.git@outlook.com>
Co-authored-by: LiRen Tu <tuliren@gmail.com>

* Revert "Add skeleton for databricks destination (#5629)" (#6066)

This reverts commit 79256c4.

* 🎉 New Destination: Databricks (#5998)

Implement new destination connector for databricks delta lake.
Resolves #2075.

Co-authored-by: George Claireaux <george@claireaux.co.uk>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

* Source PostHog: add support for self-hosted instances (#6058)

* publish #6058 (#6059)

* Destination Kafka: correct spec json and data types in config (#6040)

* correct spec json and data types in config

* bump version

* correct tests

* correct config parser NPE

* format files

Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local>

* Fix or delete broken links (#6069)

* Fix more doc issues (#6072)

* 🎉 Added optional platform flag for build image script (#6000)

* Fix dependabot security alert. (#6073)

* Pin set value to greater than 4.0.1 to fix security warning.

* Format the rest of the connectors.

* add coverage report (#6045)

Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com>

* Fix the format of the data returned by Google Ads oauth to match the config accepted by the connector (#6032)

* update salesforce docs (#6081)

* 🎉 Source Github: add caching for all streams (#5949)

* Source Github: add checking for all streams

* bump version, update changelogs

* Disable automatic migration acceptance test (#5988)

- The automatic migration acceptance test no longer works because of the new Flyway migration system.
- The file-based migration system is being deprecated.

* 🎉 CDK: Add requests native authenticator support (#5731)

* Add requests native auth class

* Update init file.
Update type annotations.
Bump version.

* Update TokenAuthenticator implementation.
Update Oauth2Authenticator implemetation.
Add CHANGELOG.md record.

* Update Oauth2Authenticator default value setting.
Update CHANGELOG.md

* Add requests native authenticator tests

* Add CDK requests native __call__ method tests.
Update CHANGELOG.md

* Add outdated auth deprication messages

* Update requests native auth __call__ method tests

* Bump CDK version to 0.1.20

* Interface changes to support separating secrets from the config (#6065)

* Interface changes to support separating secrets from the config
* Cleanup from PR comments and whitespace

* Update log message for empty env variable (#6115)

Co-authored-by: Jared Rhizor <jared@dataline.io>

* Bump Airbyte version from 0.29.17-alpha to 0.29.18-alpha (#6125)

Co-authored-by: davinchia <davinchia@users.noreply.github.com>

* return auth spec in the API when getting definition specification (#6121)

* Ignore python test coverage files (#6144)

* CDK: support nested refs resolving (#6044)

Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com>

* feat: path for nested fields (#6130)

* feat: path for nested fields

* fix: clipRule error

* fix: remove field name

* Fix request middleware for ConnectionService (#6148)

* Jamakase/update onboarding flow (#5656)

* Doc explains normalization full-refresh implications (#6097)

* update docs

* add info in quickstart connection page

* update abhi comments

Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local>

* Fix migration validation issue (#6154)

Resolves #6151.

* Bump Airbyte version from 0.29.18-alpha to 0.29.19-alpha (#6156)

Co-authored-by: tuliren <tuliren@users.noreply.github.com>

* Add information on which destinations support Incremental - Deduped History in their docs (#6031)

Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

* Update Airbyte Spec acknowledgements. (#6155)

Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>

* Update new integration request

* Add back the migration acceptance test (#6163)

* 🎉 Create a Helm Chart For Airbyte (#5891)

See number #1868. This creates an initial helm chart for installing Airbyte in Kubernetes to make it easier for users who are more familiar with helm. It also includes GitHub actions to help continually test that the chart works in the most basic case.
All of the templates are based off of the kustomize folder, but minio and postgres have been removed in favor of adding the bitnami helm charts as dependencies since they have an active community and allow easily tweaking their install.

* Fix OAuth Summary strings (#6143)

Co-authored-by: Marcos Eliziario Santos <eliziario@users.noreply.github.com>
Co-authored-by: Marcos Eliziario Santos <marcos@coremarcos.com>
Co-authored-by: oleh.zorenko <19872253+Zirochkaa@users.noreply.github.com>
Co-authored-by: Mauro <35332423+m-ronchi@users.noreply.github.com>
Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Co-authored-by: Jared Rhizor <jared@dataline.io>
Co-authored-by: George Claireaux <george@claireaux.co.uk>
Co-authored-by: Liren Tu <tuliren.git@outlook.com>
Co-authored-by: LiRen Tu <tuliren@gmail.com>
Co-authored-by: coeurdestenebres <90490546+coeurdestenebres@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Marcos Marx <marcosmarx@MacBook-Pro-de-Marcos.local>
Co-authored-by: Harsha Teja Kanna <h7kanna@users.noreply.github.com>
Co-authored-by: Davin Chia <davinchia@gmail.com>
Co-authored-by: Dmytro <avida.d3@gmail.com>
Co-authored-by: Dmytro Rezchykov <dmitry.rezchykov@zazmic.com>
Co-authored-by: Yevhenii <34103125+yevhenii-ldv@users.noreply.github.com>
Co-authored-by: Jenny Brown <85510829+airbyte-jenny@users.noreply.github.com>
Co-authored-by: davinchia <davinchia@users.noreply.github.com>
Co-authored-by: Iakov Salikov <36078770+isalikov@users.noreply.github.com>
Co-authored-by: Artem Astapenko <3767150+Jamakase@users.noreply.github.com>
Co-authored-by: tuliren <tuliren@users.noreply.github.com>
Co-authored-by: Abhi Vaidyanatha <abhi@airbyte.io>
Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>
Co-authored-by: Jonathan Stacks <jonstacks@users.noreply.github.com>
Co-authored-by: Christophe Duong <christophe.duong@gmail.com>
@github-actions github-actions bot added area/api Related to the api area/platform issues related to the platform area/documentation Improvements or additions to documentation area/frontend area/worker Related to worker CDK Connector Development Kit labels Sep 17, 2021
…thub.com:airbytehq/airbyte into htrueman/source-amazon-sp-extra-endpoint-support
@github-actions github-actions bot removed area/platform issues related to the platform area/worker Related to worker area/documentation Improvements or additions to documentation area/frontend area/api Related to the api CDK Connector Development Kit labels Sep 17, 2021
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Sep 17, 2021
@htrueman
Copy link
Contributor Author

htrueman commented Sep 17, 2021

/publish connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1245353817
❌ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1245353817

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 11:55 Inactive
@htrueman
Copy link
Contributor Author

htrueman commented Sep 17, 2021

/publish connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1245415903
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/1245415903

@jrhizor jrhizor temporarily deployed to more-secrets September 17, 2021 12:16 Inactive
@htrueman htrueman merged commit 58b6a1b into master Sep 17, 2021
@htrueman htrueman deleted the htrueman/source-amazon-sp-extra-endpoint-support branch September 17, 2021 12:32
@htrueman
Copy link
Contributor Author

@sherifnada according to #5248 (comment) the #6217 issue created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon SP: Support (even) more API endpoints
6 participants