🎉 Amazon SP extra endpoint support #5157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled with locations and projectID (#5049) * [3549] Destination:BigQuery: Added more logs and updated the way BigQuery job is created
Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>
* add more-secrets environment to publish and test workflows * add link to more-secrets environment in relevant docs location
Previously, when Airbyte exported configurations, even if there were not configurations of a type (e.g. operations) it would create a placeholder file for it in the export archive. The implementation has changed such that we cannot make that guarantee anymore. Specifically the postgres database only exports data that it actually has. The migration assumed that every archive it processed would contain data from all types. This commit makes the change to make sure that the types represented in the archive just need to be a subset of the types declared in the schema. In the future we can decide if we have an opinion on whether we should always export placeholder files. Since we have versions of Airbyte that don't do it though, we need to make this change in the migration code.
* minor line length changes * cdk generated source + oop structure + start of implementation * fixed some broken syntax stuff * pre-pyarrow convert * introducing pyarrow * skeleton for unit tests * read working on multiple files * incremental first draft * blobfile -> fileclient * change references of 'blob' to 'file' * minor tidy to make draft PR * fixes * addressed review comments + more unit tests * finished unit tests * bugfixes and abstract integration tests framework * remove old commented stuff * docstrings * restructure as source-s3 * Delete playground.py * integration tests * acceptance tests and some more reshuffling * source S3 credentials * change _airbyte_ columns to _ab_ * update spec with better descriptions and ordering * created s3 source docs * source definition * reverse docstring change in cdk * reverse docstring change * reverse change * reverse docstring change * remove TODO comments * add PR to changelog * removed unused libraries * formatting & address some review comments * rename of files/classes for clarity * addressing review comments * address reviews * add s3 source * building spec with pydantic for provider-specific inheritance * pydantic spec and improved path pattern with wcmatch.glob * update path patterns info in doc * formatting * tests gzip and bz2 compression on csv * updated compression support in doc * forgot to upload bz2 test file * added pattern validation to dataset * formatting * Format. * ran testScaffoldTemplates & generated this diff * bumped version because of documentationUrl fix Co-authored-by: Davin Chia <davinchia@gmail.com>
…zon-sp-extra-endpoint-support
github-actions
bot
added
area/connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #4936
How
Added additional streams support.
Recommended reading order
source.pystreams.pyPre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
airbyte_secretin the connector's spec./gradlew :airbyte-integrations:connectors:<name>:integrationTest./test connector=connectors/<name>command as documented here is passing.README.mddocs/SUMMARY.mdif it's a new connectordocs/integrations/<source or destination>/<name>.docs/integrations/.... See changelog exampledocs/integrations/README.mdcontains a reference to the new connector/publishcommand described hereConnector Generator checklist
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes