Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-twilio: fixes to make acceptance tests pass #12183

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Apr 20, 2022

What

Acceptance tests run on source-twilio were failing. I try to make the required fix in this PR.
Closes #9225

How

  • Fix schemas: Add a new streams property in the calls stream's subresource_uris (probably a new subresource that is now returned by the Twilio API.
  • Declare a valid primary key for the conference_participants stream
  • Define message_medias and conferences as empty stream in the acceptance test config as our sandbox account does not have data for these streams

@alafanechere alafanechere marked this pull request as ready for review April 20, 2022 15:04
@github-actions github-actions bot added the area/connectors Connector related issues label Apr 20, 2022
@alafanechere
Copy link
Contributor Author

alafanechere commented Apr 20, 2022

/test connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2196556564
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2196556564
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  886    259    71%

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @alafanechere can you create an issue to add data to the empty streams in the future?

@alafanechere
Copy link
Contributor Author

LGTM @alafanechere can you create an issue to add data to the empty streams in the future?

Done: #12232

@alafanechere
Copy link
Contributor Author

alafanechere commented Apr 21, 2022

/publish connector=connectors/source-twilio

🕑 connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2200361093
🚀 Successfully published connectors/source-twilio
🚀 Auto-bumped version for connectors/source-twilio
✅ connectors/source-twilio https://github.com/airbytehq/airbyte/actions/runs/2200361093

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 21, 2022 07:43 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets April 21, 2022 07:44 Inactive
@alafanechere alafanechere merged commit f193896 into master Apr 21, 2022
@alafanechere alafanechere deleted the augustin/source-twilio/fix-bad-requests branch April 21, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Twilio: Failed with Integration Tests
3 participants