Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-twilio: fixes to make acceptance tests pass #12183

Merged
merged 3 commits into from
Apr 21, 2022
Merged

source-twilio: fixes to make acceptance tests pass #12183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4770b71
make acceptance tests pass
alafanechere Apr 20, 2022
b545a35
bump version
alafanechere Apr 20, 2022
dc9aec4
auto-bump connector version
octavia-squidington-iii Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-config/init/src/main/resources/seed/source_definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@
- name: Twilio
sourceDefinitionId: b9dc6155-672e-42ea-b10d-9f1f1fb95ab1
dockerRepository: airbyte/source-twilio
dockerImageTag: 0.1.2
dockerImageTag: 0.1.3
documentationUrl: https://docs.airbyte.io/integrations/sources/twilio
icon: twilio.svg
sourceType: api
Expand Down
4 changes: 2 additions & 2 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8609,9 +8609,9 @@
oauthFlowOutputParameters:
- - "token"
- - "key"
- dockerImage: "airbyte/source-twilio:0.1.2"
- dockerImage: "airbyte/source-twilio:0.1.3"
spec:
documentationUrl: "https://hub.docker.com/r/airbyte/source-twilio"
documentationUrl: "https://docs.airbyte.io/integrations/sources/twilio"
connectionSpecification:
$schema: "http://json-schema.org/draft-07/schema#"
title: "Twilio Spec"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-twilio/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.version=0.1.3
LABEL io.airbyte.name=airbyte/source-twilio
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-twilio/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ tests:
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/no_empty_streams_catalog.json"
empty_streams: ["message_media", "conferences"]
incremental:
- config_path: "secrets/config.json"
# usage records stream produces and error if cursor date gte than current date
Expand Down
3 changes: 3 additions & 0 deletions airbyte-integrations/connectors/source-twilio/source_twilio/schemas/calls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,9 @@
},
"feedback_summaries": {
"type": ["null", "string"]
},
"streams": {
"type": ["null", "string"]
}
}
}
Expand Down
1 change: 1 addition & 0 deletions airbyte-integrations/connectors/source-twilio/source_twilio/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ class ConferenceParticipants(TwilioNestedStream):
which are on conference call at the moment request is made).
"""

primary_key = ["account_sid", "conference_sid"]
parent_stream = Conferences
data_field = "participants"

Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/twilio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ See [docs](https://www.twilio.com/docs/iam/api) for more details.

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.3 | 2022-04-20 | [12183](https://github.com/airbytehq/airbyte/pull/12183) | Add new subresource on the call stream + declare a valid primary key for conference_participants stream |
| 0.1.2 | 2021-12-23 | [9092](https://github.com/airbytehq/airbyte/pull/9092) | Correct specification doc URL |
| 0.1.1 | 2021-10-18 | [7034](https://github.com/airbytehq/airbyte/pull/7034) | Update schemas and transform data types according to the API schema |
| 0.1.0 | 2021-07-02 | [4070](https://github.com/airbytehq/airbyte/pull/4070) | Native Twilio connector implemented |
Expand Down