Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart ingress and temporal values #15503

Closed
wants to merge 1 commit into from

Conversation

Rukesh-Kapuluru
Copy link

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

  • Helm chart issues.
  • Backend in ingress doesn't match the service name.
  • No option to specify external postgresql hostname for temporal.

How

Describe the solution

  • Modified the ingress template to use the correct backend name.
  • Provided an option in temporal chart to pass the external hostname for temporal.Set the default value to match the current value so existing chart users are not impacted.

Recommended reading order

  1. ingress.yaml
  2. deployment.yaml
  3. values.yaml

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

No breaking changes

@github-actions github-actions bot added area/platform issues related to the platform kubernetes labels Aug 10, 2022
@xpuska513
Copy link
Contributor

Changes are included in #15510

@xpuska513 xpuska513 closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform kubernetes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants