Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart ingress and temporal values #15503

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/airbyte-temporal/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ spec:
name: {{ .Values.global.database.secretName | default (printf "%s-postgresql" .Release.Name ) }}
key: {{ .Values.global.database.secretValue | default "postgresql-password" }}
- name: POSTGRES_SEEDS
value: {{ .Release.Name }}-postgresql
value: {{ .Values.externalHost | default (printf "%s-postgresql" .Release.Name ) }}
- name: DYNAMIC_CONFIG_FILE_PATH
value: "config/dynamicconfig/development.yaml"
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions charts/airbyte-temporal/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ image:
pullPolicy: IfNotPresent
tag: "1.7.0"

## @param temporal.externalHost The external postgresql host for temporal instance
externalHost: ""

## @param temporal.service.type The Kubernetes Service Type
## @param temporal.service.port The temporal port and exposed kubernetes port
service:
Expand Down
4 changes: 2 additions & 2 deletions charts/airbyte-webapp/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ spec:
backend:
{{- if semverCompare ">=1.19-0" $.Capabilities.KubeVersion.GitVersion }}
service:
name: {{ $fullName }}-webapp
name: {{ $fullName }}
port:
number: {{ $svcPort }}
{{- else }}
serviceName: {{ $fullName }}-webapp
serviceName: {{ $fullName }}
servicePort: {{ $svcPort }}
{{- end }}
{{- end }}
Expand Down